From eec5249eb67179f8943371319db140daac116121 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 20 Jul 2013 16:01:44 -0400
Subject: [PATCH] possible fix for wront sorting on /recent

---
 src/categories.js | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/categories.js b/src/categories.js
index 78fce48cbe..408eaf8fbb 100644
--- a/src/categories.js
+++ b/src/categories.js
@@ -128,7 +128,6 @@ var	RDB = require('./redis.js'),
 	Categories.getTopicsByTids = function(tids, current_user, callback, category_id /*temporary*/) {
 
 		var retrieved_topics = [];
-		var topicCountToLoad = tids.length;
 		
 		function getTopicInfo(topicData, callback) {
 
@@ -177,9 +176,8 @@ var	RDB = require('./redis.js'),
 			return !deleted || (deleted && topicInfo.privileges.view_deleted) || topicData.uid === current_user;
 		}
 
-		for(var i=0; i<tids.length; ++i) {
-
-			topics.getTopicData(tids[i], function(topicData) {
+		function loadTopic(tid, callback) {
+			topics.getTopicData(tid, function(topicData) {
 
 				getTopicInfo(topicData, function(topicInfo) {
 
@@ -198,15 +196,17 @@ var	RDB = require('./redis.js'),
 
 					if (isTopicVisible(topicData, topicInfo))
 						retrieved_topics.push(topicData);
-					else
-						--topicCountToLoad;
-
-					if(retrieved_topics.length === topicCountToLoad) {
-						callback(retrieved_topics);
-					}
+					
+					callback(null);					
 				});
 			});
 		}
+		
+		async.eachSeries(tids, loadTopic, function(err) {
+			if(!err) {
+				callback(retrieved_topics);
+			}
+		});
 
 	}