From e98f184868a72d8083dd9bda8105bef44578ce29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Fri, 31 May 2024 11:49:34 -0400 Subject: [PATCH] refactor: add sanity checks to sio --- src/socket.io/posts/votes.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/socket.io/posts/votes.js b/src/socket.io/posts/votes.js index a7426e49ba..3a92360535 100644 --- a/src/socket.io/posts/votes.js +++ b/src/socket.io/posts/votes.js @@ -5,11 +5,17 @@ const sockets = require('../index'); module.exports = function (SocketPosts) { SocketPosts.getVoters = async function (socket, data) { + if (!data || !data.pid) { + throw new Error('[[error:invalid-data]]'); + } sockets.warnDeprecated(socket, 'GET /api/v3/posts/:pid/voters'); return await api.posts.getVoters(socket, { pid: data.pid }); }; SocketPosts.getUpvoters = async function (socket, pids) { + if (!Array.isArray(pids)) { + throw new Error('[[error:invalid-data]]'); + } sockets.warnDeprecated(socket, 'GET /api/v3/posts/:pid/upvoters'); return await api.posts.getUpvoters(socket, { pid: pids[0] }); };