Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-14 02:27:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: make translator.unescape stricter like escape

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2026-01-16 13:17:02 -05:00
parent b2fa7304e9
commit e505e36991
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
public/src/modules/translator.common.js
View File

@@ -475,7 +475,7 @@ module.exports = function (utils, load, warn) {
*/
Translator.unescape = function unescape(text) {
return typeof text === 'string' ?
text.replace(/]]/g, ']]').replace(/[[/g, '[[') :
text.replace(/[[([a-zA-Z0-9_.-]+:[a-zA-Z0-9_.-]+)]]/g, '[[$1]]') :
text;
};

12
test/translator.js
View File

@@ -326,7 +326,7 @@ describe('Translator static methods', () => {
done();
});
});
describe('.escape', () => {
describe('.escape/.unescape', () => {
it('should escape translation patterns within text', (done) => {
assert.strictEqual(
Translator.escape('some nice text [[global:home]] here'),
@@ -350,9 +350,7 @@ describe('Translator static methods', () => {
);
done();
});
});
describe('.unescape', () => {
it('should unescape escaped translation patterns within text', (done) => {
assert.strictEqual(
Translator.unescape('some nice text [[global:home]] here'),
@@ -360,6 +358,14 @@ describe('Translator static methods', () => {
);
done();
});
it('should not unescape markdown links', (done) => {
assert.strictEqual(
Translator.unescape('&lsqblink text &lsqbtest]](https://example.org)'),
'&lsqblink text &lsqbtest]](https://example.org)'
);
done();
});
});
describe('.compile', () => {