From e4765714ca8287ffe31d224453822042d275c4ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 11 Oct 2023 13:03:43 -0400 Subject: [PATCH] use absolute urls for breadcrumbs --- install/package.json | 2 +- src/controllers/helpers.js | 10 +++++----- src/controllers/topics.js | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/install/package.json b/install/package.json index ef3e2fb43a..bc58ab981c 100644 --- a/install/package.json +++ b/install/package.json @@ -102,7 +102,7 @@ "nodebb-plugin-ntfy": "1.7.3", "nodebb-plugin-spam-be-gone": "2.2.0", "nodebb-rewards-essentials": "0.2.3", - "nodebb-theme-harmony": "1.1.82", + "nodebb-theme-harmony": "1.1.83", "nodebb-theme-lavender": "7.1.4", "nodebb-theme-peace": "2.1.22", "nodebb-theme-persona": "13.2.38", diff --git a/src/controllers/helpers.js b/src/controllers/helpers.js index 4e4c562741..a4a2287160 100644 --- a/src/controllers/helpers.js +++ b/src/controllers/helpers.js @@ -197,7 +197,7 @@ helpers.buildCategoryBreadcrumbs = async function (cid) { if (!data.disabled && !data.isSection) { breadcrumbs.unshift({ text: String(data.name), - url: `${relative_path}/category/${data.slug}`, + url: `${url}/category/${data.slug}`, cid: cid, }); } @@ -206,13 +206,13 @@ helpers.buildCategoryBreadcrumbs = async function (cid) { if (meta.config.homePageRoute && meta.config.homePageRoute !== 'categories') { breadcrumbs.unshift({ text: '[[global:header.categories]]', - url: `${relative_path}/categories`, + url: `${url}/categories`, }); } breadcrumbs.unshift({ text: meta.config.homePageTitle || '[[global:home]]', - url: `${relative_path}/`, + url: url, }); return breadcrumbs; @@ -222,14 +222,14 @@ helpers.buildBreadcrumbs = function (crumbs) { const breadcrumbs = [ { text: meta.config.homePageTitle || '[[global:home]]', - url: `${relative_path}/`, + url: url, }, ]; crumbs.forEach((crumb) => { if (crumb) { if (crumb.url) { - crumb.url = `${utils.isRelativeUrl(crumb.url) ? relative_path : ''}${crumb.url}`; + crumb.url = `${utils.isRelativeUrl(crumb.url) ? `${url}/` : ''}${crumb.url}`; } breadcrumbs.push(crumb); } diff --git a/src/controllers/topics.js b/src/controllers/topics.js index 05de930053..7a57c0e5c4 100644 --- a/src/controllers/topics.js +++ b/src/controllers/topics.js @@ -182,7 +182,7 @@ async function buildBreadcrumbs(topicData) { const breadcrumbs = [ { text: topicData.category.name, - url: `${relative_path}/category/${topicData.category.slug}`, + url: `${url}/category/${topicData.category.slug}`, cid: topicData.category.cid, }, {