Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-14 10:37:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: get rid of map, move parallel calls into promise.all

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2026-01-22 11:49:16 -05:00
parent f29c9f064b
commit e231c010f6
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/user/digest.js
View File

@@ -163,25 +163,25 @@ Digest.send = async function (data) {
}; };
Digest.getDeliveryTimes = async (start, stop) => { Digest.getDeliveryTimes = async (start, stop) => {
const count = await db.sortedSetCard('users:joindate'); const [count, uids] = await Promise.all([
const uids = await user.getUidsFromSet('users:joindate', start, stop); db.sortedSetCard('users:joindate'),
user.getUidsFromSet('users:joindate', start, stop),
]);
if (!uids.length) { if (!uids.length) {
return []; return { users: [], count };
} }
const [scores, settings] = await Promise.all([ const [scores, settings, userData] = await Promise.all([
// Grab the last time a digest was successfully delivered to these uids // Grab the last time a digest was successfully delivered to these uids
db.sortedSetScores('digest:delivery', uids), db.sortedSetScores('digest:delivery', uids),
// Get users' digest settings // Get users' digest settings
Digest.getUsersInterval(uids), Digest.getUsersInterval(uids),
user.getUsersFields(uids, ['username', 'picture']),
]); ]);
// Populate user data userData.forEach((user, idx) => {
let userData = await user.getUsersFields(uids, ['username', 'picture']);
userData = userData.map((user, idx) => {
user.lastDelivery = scores[idx] ? new Date(scores[idx]).toISOString() : '[[admin/manage/digest:null]]'; user.lastDelivery = scores[idx] ? new Date(scores[idx]).toISOString() : '[[admin/manage/digest:null]]';
user.setting = settings[idx]; user.setting = settings[idx];
return user;
}); });
return { return {