Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-05-06 12:27:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: only remove deleted tag, closes #11515

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2023-04-24 15:39:00 -04:00
parent 21fb8590e5
commit de2669a2c6
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/topics/tags.js
View File

@@ -232,10 +232,15 @@ module.exports = function (Topics) {
if (!tids.length) { if (!tids.length) {
return; return;
} }
let topicsTags = await Topics.getTopicsTags(tids);
topicsTags = topicsTags.map(
topicTags => topicTags.filter(topicTag => topicTag && topicTag !== tag)
);
await db.deleteObjectFields( await db.setObjectBulk(
tids.map(tid => `topic:${tid}`), tids.map((tid, index) => ([
['tags'], `topic:${tid}`, { tags: topicsTags[index].join(',') },
]))
); );
}); });
} }

8
test/topics.js
View File

@@ -1932,6 +1932,14 @@ describe('Topic\'s', () => {
}); });
}); });
it('should only delete one tag from topic', async () => {
const result1 = await topics.post({ uid: adminUid, tags: ['deleteme1', 'deleteme2', 'deleteme3'], title: 'topic tagged with plugins', content: 'topic 1 content', cid: topic.categoryId });
await topics.deleteTag('deleteme2');
const topicData = await topics.getTopicData(result1.topicData.tid);
const tags = topicData.tags.map(t => t.value);
assert.deepStrictEqual(tags, ['deleteme1', 'deleteme3']);
});
it('should delete tag', (done) => { it('should delete tag', (done) => {
topics.deleteTag('javascript', (err) => { topics.deleteTag('javascript', (err) => {
assert.ifError(err); assert.ifError(err);