Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-05-07 06:07:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix wrong error returns, more tests

Browse Source
This commit is contained in:
barisusakli
2016-10-26 16:38:42 +03:00
parent 5ceaf86c3d
commit d8a9df74d7
5 changed files with 178 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/socket.io/posts/flag.js
View File

@@ -107,7 +107,7 @@ module.exports = function (SocketPosts) {
SocketPosts.dismissFlag = function (socket, pid, callback) {
if (!pid || !socket.uid) {
return callback('[[error:invalid-data]]');
return callback(new Error('[[error:invalid-data]]'));
}
async.waterfall([
function (next) {
@@ -138,7 +138,7 @@ module.exports = function (SocketPosts) {
SocketPosts.updateFlag = function (socket, data, callback) {
if (!data || !(data.pid && data.data)) {
return callback('[[error:invalid-data]]');
return callback(new Error('[[error:invalid-data]]'));
}
var payload = {};

2
src/socket.io/user/picture.js
View File

@@ -11,7 +11,7 @@ module.exports = function (SocketUser) {
SocketUser.changePicture = function (socket, data, callback) {
if (!socket.uid) {
return callback('[[error:invalid-uid]]');
return callback(new Error('[[error:invalid-uid]]'));
}
if (!data) {

9
src/socket.io/user/profile.js
View File

@@ -84,12 +84,13 @@ module.exports = function (SocketUser) {
}
SocketUser.changePassword = function (socket, data, callback) {
if (!socket.uid) {
return callback(new Error('[[error:invalid-uid]]'));
}
if (!data || !data.uid) {
return callback(new Error('[[error:invalid-data]]'));
}
if (!socket.uid) {
return callback('[[error:invalid-uid]]');
}
user.changePassword(socket.uid, data, function (err) {
if (err) {
@@ -108,7 +109,7 @@ module.exports = function (SocketUser) {
SocketUser.updateProfile = function (socket, data, callback) {
if (!socket.uid) {
return callback('[[error:invalid-uid]]');
return callback(new Error('[[error:invalid-uid]]'));
}
if (!data || !data.uid) {