Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-08-27 01:15:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

granting and rescinding ownership, #2588

Browse Source
This commit is contained in:
Julian Lam
2015-01-08 15:13:05 -05:00
parent a907fa2187
commit d747ce5760
4 changed files with 91 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/controllers/groups.js
View File

@@ -23,10 +23,12 @@ groupsController.list = function(req, res, next) {
groupsController.details = function(req, res, next) {
var uid = req.user ? parseInt(req.user.uid, 10) : 0;
async.parallel({
group: function(next) {
groups.get(req.params.name, {
expand: true
expand: true,
uid: uid
}, next);
},
posts: function(next) {

55
src/groups.js
View File

@@ -71,25 +71,7 @@ var async = require('async'),
groupNames = groupNames.concat(ephemeralGroups);
async.map(groupNames, function (groupName, next) {
async.waterfall([
async.apply(Groups.get, groupName, options),
function(groupObj, next) {
// Retrieve group membership state, if uid is passed in
if (!options.uid) {
return next(null, groupObj);
}
Groups.isMember(options.uid, groupName, function(err, isMember) {
if (err) {
winston.warn('[groups.list] Could not determine membership in group `' + groupName + '` for uid `' + options.uid + '`: ' + err.message);
return next(null, groupObj);
}
groupObj.isMember = isMember;
next(null, groupObj);
});
}
], next);
Groups.get(groupName, options, next);
}, function (err, groups) {
callback(err, internals.filterGroups(groups, options));
});
@@ -126,6 +108,9 @@ var async = require('async'),
async.waterfall([
async.apply(async.map, uids, user.getUserData),
function(users, next) {
// Filter out non-matches
users = users.filter(Boolean);
async.mapLimit(users, 10, function(userObj, next) {
Groups.ownership.isOwner(userObj.uid, groupName, function(err, isOwner) {
if (err) {
@@ -143,6 +128,36 @@ var async = require('async'),
next(err, uids);
}
});
},
isMember: function(next) {
// Retrieve group membership state, if uid is passed in
if (!options.uid) {
return next();
}
Groups.isMember(options.uid, groupName, function(err, isMember) {
if (err) {
winston.warn('[groups.get] Could not determine membership in group `' + groupName + '` for uid `' + options.uid + '`: ' + err.message);
return next();
}
next(null, isMember);
});
},
isOwner: function(next) {
// Retrieve group ownership state, if uid is passed in
if (!options.uid) {
return next();
}
Groups.ownership.isOwner(options.uid, groupName, function(err, isOwner) {
if (err) {
winston.warn('[groups.get] Could not determine ownership in group `' + groupName + '` for uid `' + options.uid + '`: ' + err.message);
return next();
}
next(null, isOwner);
});
}
}, function (err, results) {
if (err || !results.base) {
@@ -157,6 +172,8 @@ var async = require('async'),
results.base.system = !!parseInt(results.base.system, 10);
results.base.deletable = !results.base.system;
results.base.truncated = truncated;
results.base.isMember = results.isMember;
results.base.isOwner = results.isOwner;
callback(err, results.base);
});

28
src/socket.io/groups.js
View File

@@ -20,4 +20,32 @@ SocketGroups.leave = function(socket, data, callback) {
groups.leave(data.groupName, socket.uid, callback);
};
SocketGroups.grant = function(socket, data, callback) {
if (!data) {
return callback(new Error('[[error:invalid-data]]'));
}
groups.ownership.isOwner(socket.uid, data.groupName, function(err, isOwner) {
if (!isOwner) {
return callback(new Error('[[error:no-privileges]]'));
}
groups.ownership.grant(data.toUid, data.groupName, callback);
});
};
SocketGroups.rescind = function(socket, data, callback) {
if (!data) {
return callback(new Error('[[error:invalid-data]]'));
}
groups.ownership.isOwner(socket.uid, data.groupName, function(err, isOwner) {
if (!isOwner) {
return callback(new Error('[[error:no-privileges]]'));
}
groups.ownership.rescind(data.toUid, data.groupName, callback);
});
};
module.exports = SocketGroups;