Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-07-06 20:08:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(socket.io): deprecate socketGroups.searchMembers in favour of api.groups.listMembers

Browse Source
This commit is contained in:
Julian Lam
2023-11-01 15:06:35 -04:00
parent b61e814787
commit d2f3333af0
7 changed files with 94 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/api/groups.js
View File

@@ -73,6 +73,35 @@ groupsAPI.delete = async function (caller, data) {
});
};
groupsAPI.listMembers = async (caller, data) => {
const groupName = await groups.getGroupNameByGroupSlug(data.slug);
await canSearchMembers(caller.uid, groupName);
if (!await privileges.global.can('search:users', caller.uid)) {
throw new Error('[[error:no-privileges]]');
}
return await groups.searchMembers({
uid: caller.uid,
query: data.query,
groupName,
});
};
async function canSearchMembers(uid, groupName) {
const [isHidden, isMember, hasAdminPrivilege, isGlobalMod, viewGroups] = await Promise.all([
groups.isHidden(groupName),
groups.isMember(uid, groupName),
privileges.admin.can('admin:groups', uid),
user.isGlobalModerator(uid),
privileges.global.can('view:groups', uid),
]);
if (!viewGroups || (isHidden && !isMember && !hasAdminPrivilege && !isGlobalMod)) {
throw new Error('[[error:no-privileges]]');
}
}
groupsAPI.join = async function (caller, data) {
if (!data) {
throw new Error('[[error:invalid-data]]');