Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-27 17:11:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: broken test for bad topic thumbs logic

Browse Source
This commit is contained in:
Julian Lam
2020-12-09 16:23:31 -05:00
parent 3e54b70c06
commit ce8057f389
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/topicThumbs.js
View File

@@ -28,7 +28,7 @@ describe('Topic thumbs', () => {
let fooJar; let fooJar;
let fooCSRF; let fooCSRF;
let fooUid; let fooUid;
const thumbPaths = ['files/test.png', 'files/test2.png', 'https://example.org']; const thumbPaths = [`${nconf.get('upload_path')}/files/test.png`, `${nconf.get('upload_path')}/files/test2.png`, 'https://example.org'];
const uuid = utils.generateUUID(); const uuid = utils.generateUUID();
function createFiles() { function createFiles() {
@@ -88,7 +88,7 @@ describe('Topic thumbs', () => {
assert.deepStrictEqual(thumbs, [{ assert.deepStrictEqual(thumbs, [{
id: 1, id: 1,
name: 'test.png', name: 'test.png',
url: `${nconf.get('upload_url')}/${thumbPaths[0]}`, url: `${nconf.get('upload_url')}${thumbPaths[0]}`,
}]); }]);
}); });
@@ -98,7 +98,7 @@ describe('Topic thumbs', () => {
[{ [{
id: 1, id: 1,
name: 'test.png', name: 'test.png',
url: `${nconf.get('upload_url')}/${thumbPaths[0]}`, url: `${nconf.get('upload_url')}${thumbPaths[0]}`,
}], }],
[], [],
]); ]);
@@ -147,7 +147,7 @@ describe('Topic thumbs', () => {
{ {
id: 2, id: 2,
name: 'test.png', name: 'test.png',
url: `${nconf.get('upload_url')}/${thumbPaths[0]}`, url: `${nconf.get('upload_url')}${thumbPaths[0]}`,
}, },
{ {
id: 2, id: 2,
@@ -157,7 +157,7 @@ describe('Topic thumbs', () => {
{ {
id: 2, id: 2,
name: 'test2.png', name: 'test2.png',
url: `${nconf.get('upload_url')}/${thumbPaths[1]}`, url: `${nconf.get('upload_url')}${thumbPaths[1]}`,
}, },
]); ]);
}); });
@@ -172,7 +172,7 @@ describe('Topic thumbs', () => {
await topics.thumbs.delete(1, thumbPaths[0]); await topics.thumbs.delete(1, thumbPaths[0]);
assert.strictEqual(await db.isSortedSetMember('topic:1:thumbs', thumbPaths[0]), false); assert.strictEqual(await db.isSortedSetMember('topic:1:thumbs', thumbPaths[0]), false);
assert.strictEqual(await file.exists(`${nconf.get('upload_path')}/${thumbPaths[0]}`), false); assert.strictEqual(await file.exists(`${nconf.get('upload_path')}${thumbPaths[0]}`), false);
}); });
it('should also work with UUIDs', async () => { it('should also work with UUIDs', async () => {
@@ -183,7 +183,7 @@ describe('Topic thumbs', () => {
await topics.thumbs.delete(uuid, thumbPaths[1]); await topics.thumbs.delete(uuid, thumbPaths[1]);
assert.strictEqual(await db.isSortedSetMember(`draft:${uuid}:thumbs`, thumbPaths[1]), false); assert.strictEqual(await db.isSortedSetMember(`draft:${uuid}:thumbs`, thumbPaths[1]), false);
assert.strictEqual(await file.exists(`${nconf.get('upload_path')}/${thumbPaths[1]}`), false); assert.strictEqual(await file.exists(`${nconf.get('upload_path')}${thumbPaths[1]}`), false);
}); });
it('should also work with URLs', async () => { it('should also work with URLs', async () => {
@@ -199,7 +199,7 @@ describe('Topic thumbs', () => {
it('should not delete the file from disk if not associated with the tid', async () => { it('should not delete the file from disk if not associated with the tid', async () => {
createFiles(); createFiles();
await topics.thumbs.delete(uuid, thumbPaths[0]); await topics.thumbs.delete(uuid, thumbPaths[0]);
assert.strictEqual(await file.exists(`${nconf.get('upload_path')}/${thumbPaths[0]}`), true); assert.strictEqual(await file.exists(`${nconf.get('upload_path')}${thumbPaths[0]}`), true);
}); });
}); });