From ce7403014a2ad33664933e5ec4ea4a21c35d6a4a Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Fri, 22 Sep 2023 16:50:29 -0400
Subject: [PATCH] test: added tests for new logic paths (toPid validation on
 post creation)

re: #12025
---
 test/topics.js | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/test/topics.js b/test/topics.js
index 07af567b25..f40925103a 100644
--- a/test/topics.js
+++ b/test/topics.js
@@ -20,6 +20,7 @@ const privileges = require('../src/privileges');
 const meta = require('../src/meta');
 const User = require('../src/user');
 const groups = require('../src/groups');
+const utils = require('../src/utils');
 const helpers = require('./helpers');
 const socketPosts = require('../src/socket.io/posts');
 const socketTopics = require('../src/socket.io/topics');
@@ -324,6 +325,51 @@ describe('Topic\'s', () => {
 			});
 		});
 
+		it('should fail to create new reply with toPid that has been purged', async () => {
+			const { postData } = await topics.post({
+				uid: topic.userId,
+				cid: topic.categoryId,
+				title: utils.generateUUID(),
+				content: utils.generateUUID(),
+			});
+			await posts.purge(postData.pid, topic.userId);
+
+			await assert.rejects(
+				topics.reply({ uid: topic.userId, content: 'test post', tid: postData.topic.tid, toPid: postData.pid }),
+				{ message: '[[error:invalid-pid]]' }
+			);
+		});
+
+		it('should fail to create a new reply with toPid that has been deleted (user cannot view_deleted)', async () => {
+			const { postData } = await topics.post({
+				uid: topic.userId,
+				cid: topic.categoryId,
+				title: utils.generateUUID(),
+				content: utils.generateUUID(),
+			});
+			await posts.delete(postData.pid, topic.userId);
+			const uid = await User.create({ username: utils.generateUUID().slice(0, 10) });
+
+			await assert.rejects(
+				topics.reply({ uid, content: 'test post', tid: postData.topic.tid, toPid: postData.pid }),
+				{ message: '[[error:invalid-pid]]' }
+			);
+		});
+
+		it('should properly create a new reply with toPid that has been deleted (user\'s own deleted post)', async () => {
+			const { postData } = await topics.post({
+				uid: topic.userId,
+				cid: topic.categoryId,
+				title: utils.generateUUID(),
+				content: utils.generateUUID(),
+			});
+			await posts.delete(postData.pid, topic.userId);
+			const uid = await User.create({ username: utils.generateUUID().slice(0, 10) });
+
+			const { pid } = await topics.reply({ uid: topic.userId, content: 'test post', tid: postData.topic.tid, toPid: postData.pid });
+			assert(pid);
+		});
+
 		it('should delete nested relies properly', async () => {
 			const result = await topics.post({ uid: fooUid, title: 'nested test', content: 'main post', cid: topic.categoryId });
 			const reply1 = await topics.reply({ uid: fooUid, content: 'reply post 1', tid: result.topicData.tid });