From c346177bb9689e4444dbcb1a441dbe91b97d021c Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Wed, 13 Mar 2024 15:41:41 -0400
Subject: [PATCH] fix: tweak user.search to better handle local usernames with
 colons in them

---
 src/user/search.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/user/search.js b/src/user/search.js
index c636ca149e..d7ce37d083 100644
--- a/src/user/search.js
+++ b/src/user/search.js
@@ -94,9 +94,11 @@ module.exports = function (User) {
 		const data = await db.getSortedSetRangeByLex(`${searchBy}:sorted`, min, max, 0, hardCap);
 		// const uids = data.map(data => data.split(':').pop());
 		const uids = data.map((data) => {
-			data = data.split(':');
-			data.shift();
-			return data.join(':');
+			if (data.includes(':https:')) {
+				return data.substring(data.indexOf(':https:') + 1);
+			}
+
+			return data.split(':').pop();
 		});
 		return uids;
 	}