diff --git a/public/src/client/groups/list.js b/public/src/client/groups/list.js index 36f1e0f3e7..06ce88ade9 100644 --- a/public/src/client/groups/list.js +++ b/public/src/client/groups/list.js @@ -32,19 +32,17 @@ define('forum/groups/list', function() { // Group searching $('#search-text').on('keydown', function(e) { - if (e.keyCode === 13) { Groups.search($(this).val()); } - }); - - $('#search-button').on('click', function() { - Groups.search($(this).siblings('input').val()); + if (e.keyCode === 13) { Groups.search(); } }); + $('#search-button').on('click', Groups.search); }; - Groups.search = function(query) { - var groupsEl = $('#groups-list'); + Groups.search = function() { + var groupsEl = $('#groups-list'), + queryEl = $('#search-text'); socket.emit('groups.search', { - query: query, + query: queryEl.val(), options: { expand: true } diff --git a/public/src/client/users.js b/public/src/client/users.js index c19c69afe6..6030f415b5 100644 --- a/public/src/client/users.js +++ b/public/src/client/users.js @@ -96,13 +96,11 @@ define('forum/users', function() { timeoutId = setTimeout(doSearch, 250); }); - $('.search select, .search .checkbox input').on('change', function() { - console.log('doing search'); + $('.search select, .search input[type="checkbox"]').on('change', function() { doSearch(); }); $('.pagination').on('click', 'a', function() { - console.log('loading page', $(this).attr('data-page')); doSearch($(this).attr('data-page')); return false; }) diff --git a/src/groups.js b/src/groups.js index 58170eeaa8..f62fda1f43 100644 --- a/src/groups.js +++ b/src/groups.js @@ -878,8 +878,8 @@ var async = require('async'), }; Groups.search = function(query, options, callback) { - if (!query || !query.length) { - return callback(null, []); + if (!query) { + query = ''; } async.waterfall([ diff --git a/src/socket.io/groups.js b/src/socket.io/groups.js index 902041d6ec..e51c2f6062 100644 --- a/src/socket.io/groups.js +++ b/src/socket.io/groups.js @@ -127,11 +127,11 @@ SocketGroups.delete = function(socket, data, callback) { }; SocketGroups.search = function(socket, data, callback) { - if (!data || !data.query) { + if (!data) { return callback(null, []); } - groups.search(data.query, data.options || {}, callback); + groups.search(data.query || '', data.options || {}, callback); }; SocketGroups.cover = {};