From 2a98a9b33428cb94aa101409c2a24dab1ed661b7 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Mon, 14 Apr 2025 13:35:22 -0400 Subject: [PATCH 1/3] fix: bug where generateHandle would throw when passed in an invalid slug --- src/categories/create.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/categories/create.js b/src/categories/create.js index f2e8f8811d..f12b2f071b 100644 --- a/src/categories/create.js +++ b/src/categories/create.js @@ -151,7 +151,15 @@ module.exports = function (Categories) { } async function generateHandle(slug) { - let taken = await meta.slugTaken(slug); + let taken; + try { + taken = await meta.slugTaken(slug); + } catch (e) { + // invalid slug passed in + slug = 'category'; + taken = true + } + let suffix; while (taken) { suffix = utils.generateUUID().slice(0, 8); From 4f13eb0338aaa397e6b12328e323d00e0d7b1a34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 16 Apr 2025 10:23:25 -0400 Subject: [PATCH 2/3] fix: closes #13336, allow main post deletion from "delete posts" tool --- public/src/client/topic/delete-posts.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/public/src/client/topic/delete-posts.js b/public/src/client/topic/delete-posts.js index 58b4058f09..8e01a839e0 100644 --- a/public/src/client/topic/delete-posts.js +++ b/public/src/client/topic/delete-posts.js @@ -31,6 +31,8 @@ define('forum/topic/delete-posts', [ postSelect.init(function () { checkButtonEnable(); showPostsSelected(); + }, { + allowMainPostSelect: true, }); showPostsSelected(); From 6832541c020ce7742019606c105e7218388d3e4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 16 Apr 2025 10:31:28 -0400 Subject: [PATCH 3/3] lint: fix semi --- src/categories/create.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/categories/create.js b/src/categories/create.js index f12b2f071b..d9d59dac59 100644 --- a/src/categories/create.js +++ b/src/categories/create.js @@ -157,7 +157,7 @@ module.exports = function (Categories) { } catch (e) { // invalid slug passed in slug = 'category'; - taken = true + taken = true; } let suffix;