From bdcd862c1bd654bb13b7154dfef57d4965c6dd2b Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Wed, 28 Feb 2024 13:29:21 -0500
Subject: [PATCH] refactor: assertTopic to only call setObject when it is a new
 topic

---
 src/activitypub/notes.js | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/src/activitypub/notes.js b/src/activitypub/notes.js
index 46919f5290..2b980ade1a 100644
--- a/src/activitypub/notes.js
+++ b/src/activitypub/notes.js
@@ -205,6 +205,8 @@ Notes.assertTopic = async (uid, id) => {
 	}
 
 	let { pid: mainPid, tid, uid: authorId, timestamp, name, content } = chain[chain.length - 1];
+	const hasTid = !!tid;
+
 	const members = await db.isSortedSetMembers(`tid:${tid}:posts`, chain.map(p => p.pid));
 	if (tid && members.every(Boolean)) {
 		// All cached, return early.
@@ -212,7 +214,18 @@ Notes.assertTopic = async (uid, id) => {
 		return tid;
 	}
 
-	const cid = tid ? await topics.getTopicField(tid, 'cid') : -1;
+	let cid;
+	let title;
+	if (hasTid) {
+		({ cid, title, mainPid } = await topics.getTopicFields(tid, ['cid', 'title', 'mainPid']));
+	} else {
+		// mainPid ok to leave as-is
+		cid = -1;
+		title = name || utils.decodeHTMLEntities(utils.stripHTMLTags(content));
+		if (title.length > meta.config.maximumTitleLength) {
+			title = `${title.slice(0, meta.config.maximumTitleLength)}...`;
+		}
+	}
 
 	// Privilege check for local categories
 	const privilege = `topics:${tid ? 'reply' : 'create'}`;
@@ -221,11 +234,6 @@ Notes.assertTopic = async (uid, id) => {
 		return null;
 	}
 
-	let title = tid ? await topics.getTopicField(tid, 'title') : name || utils.decodeHTMLEntities(utils.stripHTMLTags(content));
-	if (title.length > meta.config.maximumTitleLength) {
-		title = `${title.slice(0, meta.config.maximumTitleLength)}...`;
-	}
-
 	tid = tid || utils.generateUUID();
 
 	const unprocessed = chain.filter((p, idx) => !members[idx]);
@@ -237,11 +245,14 @@ Notes.assertTopic = async (uid, id) => {
 	];
 
 	// mainPid doesn't belong in posts zset
-	ids.pop();
-	timestamps.pop();
+	if (ids.includes(mainPid)) {
+		const idx = ids.indexOf(mainPid);
+		ids.splice(idx, 1);
+		timestamps.splice(idx, 1);
+	}
 
 	await Promise.all([
-		db.setObject(`topic:${tid}`, {
+		!hasTid ? db.setObject(`topic:${tid}`, {
 			tid,
 			uid: authorId,
 			cid: cid,
@@ -249,7 +260,7 @@ Notes.assertTopic = async (uid, id) => {
 			title,
 			slug: `${tid}/${slugify(title)}`,
 			timestamp,
-		}),
+		}) : null,
 		db.sortedSetAdd(`tid:${tid}:posts`, timestamps, ids),
 		Notes.assert(uid, unprocessed),
 	]);