Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-21 03:42:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: make a single round trip for set(s)Remove

Browse Source 
use bulkWrite
This commit is contained in:
Barış Soner Uşaklı
2026-03-09 18:33:24 -04:00
parent 997efcd18b
commit bcbb7bc444
3 changed files with 33 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/database/sets.js
View File

@@ -278,20 +278,21 @@ describe('Set methods', () => {
});
describe('setsRemove()', () => {
before((done) => {
db.setsAdd(['set1', 'set2'], 'value', done);
it('should remove a element from multiple sets', async () => {
await db.setsAdd(['set1', 'set2'], 'value');
await db.setRemove(['set1', 'set2'], 'value');
const members = await db.isMemberOfSets(['set1', 'set2'], 'value');
assert.deepStrictEqual(members, [false, false]);
});
it('should remove a element from multiple sets', (done) => {
db.setsRemove(['set1', 'set2'], 'value', function (err) {
assert.equal(err, null);
assert.equal(arguments.length, 1);
db.isMemberOfSets(['set1', 'set2'], 'value', (err, members) => {
assert.equal(err, null);
assert.deepEqual(members, [false, false]);
done();
});
});
it('should remove the sets if they are empty', async () => {
await db.setAdd('setsRemoveSet3', ['a']);
await db.setAdd('setsRemoveSet4', ['a']);
await db.setsRemove(['setsRemoveSet3', 'setsRemoveSet4'], 'a');
assert.deepStrictEqual(
await db.exists(['setsRemoveSet3', 'setsRemoveSet4']),
[false, false]
);
});
});