From b472c5894650441276d629592e155f8ccc6e05df Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Wed, 16 Oct 2024 15:22:49 -0400
Subject: [PATCH] fix: backend logic fixes for #12853

---
 public/src/client/chats/messages.js | 4 ++--
 src/middleware/assert.js            | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/public/src/client/chats/messages.js b/public/src/client/chats/messages.js
index f1339c7562..e16cd36a5b 100644
--- a/public/src/client/chats/messages.js
+++ b/public/src/client/chats/messages.js
@@ -344,14 +344,14 @@ define('forum/chats/messages', [
 				return;
 			}
 
-			api.del(`/chats/${roomId}/messages/${messageId}`, {}).then(() => {
+			api.del(`/chats/${roomId}/messages/${encodeURIComponent(messageId)}`, {}).then(() => {
 				components.get('chat/message', messageId).toggleClass('deleted', true);
 			}).catch(alerts.error);
 		});
 	};
 
 	messages.restore = function (messageId, roomId) {
-		api.post(`/chats/${roomId}/messages/${messageId}`, {}).then(() => {
+		api.post(`/chats/${roomId}/messages/${encodeURIComponent(messageId)}`, {}).then(() => {
 			components.get('chat/message', messageId).toggleClass('deleted', false);
 		}).catch(alerts.error);
 	};
diff --git a/src/middleware/assert.js b/src/middleware/assert.js
index ab778b0fcb..8d41d7365b 100644
--- a/src/middleware/assert.js
+++ b/src/middleware/assert.js
@@ -152,7 +152,6 @@ Assert.message = helpers.try(async (req, res, next) => {
 	}
 
 	if (
-		!isFinite(req.params.mid) ||
 		!(await messaging.messageExists(req.params.mid)) ||
 		!(await messaging.canViewMessage(req.params.mid, roomId || req.params.roomId, req.uid))
 	) {