Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-14 02:27:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: closes #13887, make translator.escape stricter

Browse Source 
only match [[namespace:key]] allow underscores,dashes and dots in namespace key
add test
This commit is contained in:
Barış Soner Uşaklı
2026-01-16 13:00:41 -05:00
parent 918bb04491
commit b2fa7304e9
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
public/src/modules/translator.common.js
View File

@@ -464,7 +464,7 @@ module.exports = function (utils, load, warn) {
*/
Translator.escape = function escape(text) {
return typeof text === 'string' ?
text.replace(/\[\[/g, '[[').replace(/\]\]/g, ']]') :
text.replace(/\[\[([a-zA-Z0-9_.-]+:[a-zA-Z0-9_.-]+)\]\]/g, '[[$1]]') :
text;
};

16
test/translator.js
View File

@@ -334,6 +334,22 @@ describe('Translator static methods', () => {
);
done();
});
it('should escape all translation patterns within text', (done) => {
assert.strictEqual(
Translator.escape('some nice text [[global:home]] here and [[global:search]] there'),
'some nice text [[global:home]] here and [[global:search]] there'
);
done();
});
it('should not escape markdown links', (done) => {
assert.strictEqual(
Translator.escape('[link text [test]](https://example.org)'),
'[link text [test]](https://example.org)'
);
done();
});
});
describe('.unescape', () => {