Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-08-13 05:47:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: categories.sortTidsBySet to not take cid, retrieve from tids themselves

Browse Source 
re: ##13255, this fixes the issue with topics outside of cid -1 in /world being sorted incorrectly
This commit is contained in:
Julian Lam
2025-03-19 22:18:47 -04:00
parent 87d2534a4b
commit b278e8a4ea
2 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/controllers/activitypub/topics.js
View File

@@ -52,7 +52,7 @@ controller.list = async function (req, res) {
delete data.children;
let tids = await categories.getTopicIds(cidQuery);
tids = await categories.sortTidsBySet(tids, -1, sort); // sorting not handled if cid is -1
tids = await categories.sortTidsBySet(tids, sort); // sorting not handled if cid is -1
data.topicCount = tids.length;
data.topics = await topics.getTopicsByTids(tids, { uid: req.uid });
topics.calculateTopicIndices(data.topics, start);