Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-06-23 16:19:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: closes #13458, check if plugin is system

Browse Source 
plugin before activate/deactive/install/uninstall
This commit is contained in:
Barış Soner Uşaklı
2025-06-02 09:55:20 -04:00
parent cc92702620
commit b1022566da
3 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
public/language/en-GB/error.json
View File

@@ -271,6 +271,7 @@
"invalid-plugin-id": "Invalid plugin ID", "invalid-plugin-id": "Invalid plugin ID",
"plugin-not-whitelisted": "Unable to install plugin – only plugins whitelisted by the NodeBB Package Manager can be installed via the ACP", "plugin-not-whitelisted": "Unable to install plugin – only plugins whitelisted by the NodeBB Package Manager can be installed via the ACP",
"cannot-toggle-system-plugin": "You cannot toggle the state of a system plugin",
"plugin-installation-via-acp-disabled": "Plugin installation via ACP is disabled", "plugin-installation-via-acp-disabled": "Plugin installation via ACP is disabled",
"plugins-set-in-configuration": "You are not allowed to change plugin state as they are defined at runtime (config.json, environmental variables or terminal arguments), please modify the configuration instead.", "plugins-set-in-configuration": "You are not allowed to change plugin state as they are defined at runtime (config.json, environmental variables or terminal arguments), please modify the configuration instead.",
"theme-not-set-in-configuration": "When defining active plugins in configuration, changing themes requires adding the new theme to the list of active plugins before updating it in the ACP", "theme-not-set-in-configuration": "When defining active plugins in configuration, changing themes requires adding the new theme to the list of active plugins before updating it in the ACP",

10
src/plugins/install.js
View File

@@ -156,6 +156,16 @@ module.exports = function (Plugins) {
} }
}; };
Plugins.isSystemPlugin = async function (id) {
const pluginDir = path.join(paths.nodeModules, id, 'plugin.json');
try {
const pluginData = JSON.parse(await fs.readFile(pluginDir, 'utf8'));
return pluginData && pluginData.system === true;
} catch (err) {
return false;
}
};
Plugins.isActive = async function (id) { Plugins.isActive = async function (id) {
if (nconf.get('plugins:active')) { if (nconf.get('plugins:active')) {
return nconf.get('plugins:active').includes(id); return nconf.get('plugins:active').includes(id);

6
src/socket.io/admin/plugins.js
View File

@@ -11,6 +11,9 @@ const { pluginNamePattern } = require('../../constants');
const Plugins = module.exports; const Plugins = module.exports;
Plugins.toggleActive = async function (socket, plugin_id) { Plugins.toggleActive = async function (socket, plugin_id) {
if (await plugins.isSystemPlugin(plugin_id)) {
throw new Error('[[error:cannot-toggle-system-plugin]]');
}
postsCache.reset(); postsCache.reset();
const data = await plugins.toggleActive(plugin_id); const data = await plugins.toggleActive(plugin_id);
await events.log({ await events.log({
@@ -22,6 +25,9 @@ Plugins.toggleActive = async function (socket, plugin_id) {
}; };
Plugins.toggleInstall = async function (socket, data) { Plugins.toggleInstall = async function (socket, data) {
if (await plugins.isSystemPlugin(data.id)) {
throw new Error('[[error:cannot-toggle-system-plugin]]');
}
const isInstalled = await plugins.isInstalled(data.id); const isInstalled = await plugins.isInstalled(data.id);
const isStarterPlan = nconf.get('saas_plan') === 'starter'; const isStarterPlan = nconf.get('saas_plan') === 'starter';
if ((isStarterPlan || nconf.get('acpPluginInstallDisabled')) && !isInstalled) { if ((isStarterPlan || nconf.get('acpPluginInstallDisabled')) && !isInstalled) {