From abcb200fda1e757dd74ebaac0428ed208eb8d96c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Mon, 16 Dec 2024 10:52:57 -0500 Subject: [PATCH] refactor: closes #12979, show plugin id/version on semver error --- src/plugins/index.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/plugins/index.js b/src/plugins/index.js index 37980dd55c..47676a5197 100644 --- a/src/plugins/index.js +++ b/src/plugins/index.js @@ -235,7 +235,12 @@ Plugins.normalise = async function (apiReturn) { } else { pluginMap[plugin.id].latest = pluginMap[plugin.id].latest || plugin.version; } - pluginMap[plugin.id].outdated = semver.gt(pluginMap[plugin.id].latest, pluginMap[plugin.id].version); + try { + pluginMap[plugin.id].outdated = semver.gt(pluginMap[plugin.id].latest, pluginMap[plugin.id].version); + } catch (err) { + winston.error(`plugin ID=${plugin.id}, latest=${pluginMap[plugin.id].latest}, version=${pluginMap[plugin.id].version},\n${err.stack}`); + throw err; + } }); if (nconf.get('plugins:active')) {