Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-28 01:21:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: bad error message for request body api test

Browse Source
This commit is contained in:
Julian Lam
2020-12-16 20:10:15 -05:00
parent d6de925348
commit a962935743
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/api.js
View File

@@ -235,6 +235,7 @@ describe('API', async () => {
const qs = {}; const qs = {};
Object.keys(context).forEach((_method) => { Object.keys(context).forEach((_method) => {
// Only test GET routes in the Read API
if (api.info.title === 'NodeBB Read API' && _method !== 'get') { if (api.info.title === 'NodeBB Read API' && _method !== 'get') {
return; return;
} }
@@ -279,17 +280,18 @@ describe('API', async () => {
it('should contain a valid request body (if present) with application/json or multipart/form-data type if POST/PUT/DELETE', () => { it('should contain a valid request body (if present) with application/json or multipart/form-data type if POST/PUT/DELETE', () => {
if (['post', 'put', 'delete'].includes(method) && context[method].hasOwnProperty('requestBody')) { if (['post', 'put', 'delete'].includes(method) && context[method].hasOwnProperty('requestBody')) {
assert(context[method].requestBody); const failMessage = `${method.toUpperCase()} ${path} has a malformed request body`;
assert(context[method].requestBody.content); assert(context[method].requestBody, failMessage);
assert(context[method].requestBody.content, failMessage);
if (context[method].requestBody.content.hasOwnProperty('application/json')) { if (context[method].requestBody.content.hasOwnProperty('application/json')) {
assert(context[method].requestBody.content['application/json']); assert(context[method].requestBody.content['application/json'], failMessage);
assert(context[method].requestBody.content['application/json'].schema); assert(context[method].requestBody.content['application/json'].schema, failMessage);
assert(context[method].requestBody.content['application/json'].schema.properties); assert(context[method].requestBody.content['application/json'].schema.properties, failMessage);
} else if (context[method].requestBody.content.hasOwnProperty('multipart/form-data')) { } else if (context[method].requestBody.content.hasOwnProperty('multipart/form-data')) {
assert(context[method].requestBody.content['multipart/form-data']); assert(context[method].requestBody.content['multipart/form-data'], failMessage);
assert(context[method].requestBody.content['multipart/form-data'].schema); assert(context[method].requestBody.content['multipart/form-data'].schema, failMessage);
assert(context[method].requestBody.content['multipart/form-data'].schema.properties); assert(context[method].requestBody.content['multipart/form-data'].schema.properties, failMessage);
} }
} }
}); });