Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-03 11:01:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: shorter check

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2026-02-21 18:56:53 -05:00
parent 63c9a6e03c
commit a70a62ccf9
1 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/plugins/hooks.js
View File

@@ -181,15 +181,13 @@ async function fireActionHook(hook, hookList, params) {
return; return;
} }
for (const hookObj of hookList) { for (const hookObj of hookList) {
if (!isHookValid(hook, hookObj)) { if (isHookValid(hook, hookObj)) {
continue; try {
} // eslint-disable-next-line
await hookObj.method(params);
try { } catch (err) {
// eslint-disable-next-line winston.error(`[plugins] Error in hook ${hookObj.id}@${hookObj.hook} \n${err.stack}`);
await hookObj.method(params); }
} catch (err) {
winston.error(`[plugins] Error in hook ${hookObj.id}@${hookObj.hook} \n${err.stack}`);
} }
} }
} }
@@ -255,16 +253,14 @@ async function fireResponseHook(hook, hookList, params) {
return; return;
} }
for (const hookObj of hookList) { for (const hookObj of hookList) {
if (!isHookValid(hook, hookObj)) { if (isHookValid(hook, hookObj)) {
continue; // Skip remaining hooks if headers have been sent
} if (params.res.headersSent) {
return;
}
// Skip remaining hooks if headers have been sent // eslint-disable-next-line no-await-in-loop
if (params.res.headersSent) { await hookObj.method(params);
return;
} }
// eslint-disable-next-line no-await-in-loop
await hookObj.method(params);
} }
} }