From a691be595216feea0406e0d602a79c2cf1d58e88 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Tue, 20 Oct 2020 16:09:40 -0400
Subject: [PATCH] fix: incorrect logic for post history editable bool

---
 src/socket.io/posts/diffs.js | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/socket.io/posts/diffs.js b/src/socket.io/posts/diffs.js
index 3a5f2d6a6b..fb74f6a9ef 100644
--- a/src/socket.io/posts/diffs.js
+++ b/src/socket.io/posts/diffs.js
@@ -18,8 +18,13 @@ module.exports = function (SocketPosts) {
 		let usernames = await user.getUsersFields(uids, ['username']);
 		usernames = usernames.map(userObj => (userObj.uid ? userObj.username : null));
 
-		const cid = await posts.getCidByPid(data.pid);
-		const canEdit = await privileges.categories.can('posts:edit', cid, socket.uid);
+		let canEdit = true;
+		try {
+			await user.isPrivilegedOrSelf(socket.uid, post.uid);
+		} catch (e) {
+			canEdit = false;
+		}
+
 		timestamps.push(post.timestamp);
 
 		return {