From a1c425ceab65ec95503f2be86c6d9143c1045540 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Sun, 22 Feb 2026 21:39:55 -0500 Subject: [PATCH] dont call pushCount if there are no nids --- src/topics/unread.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/topics/unread.js b/src/topics/unread.js index fd487850c0..6ee52cd6c6 100644 --- a/src/topics/unread.js +++ b/src/topics/unread.js @@ -326,7 +326,7 @@ module.exports = function (Topics) { Topics.markAllRead = async function (uid) { const tids = await Topics.getUnreadTids({ uid }); - Topics.markTopicNotificationsRead(tids, uid); + await Topics.markTopicNotificationsRead(tids, uid); await Topics.markAsRead(tids, uid); await db.delete(`uid:${uid}:tids_unread`); }; @@ -336,8 +336,10 @@ module.exports = function (Topics) { return; } const nids = await user.notifications.getUnreadByField(uid, 'tid', tids); - await notifications.markReadMultiple(nids, uid); - user.notifications.pushCount(uid); + if (nids.length) { + await notifications.markReadMultiple(nids, uid); + await user.notifications.pushCount(uid); + } }; Topics.markCategoryUnreadForAll = async function (/* tid */) {