mirror of
https://github.com/NodeBB/NodeBB.git
synced 2026-05-06 11:27:01 +02:00
refactor: replace math.random with crypto
This commit is contained in:
@@ -3,6 +3,7 @@
|
||||
module.exports = function (module) {
|
||||
const _ = require('lodash');
|
||||
const helpers = require('./helpers');
|
||||
const { secureRandom } = require('../../utils');
|
||||
|
||||
module.setAdd = async function (key, value) {
|
||||
if (!Array.isArray(value)) {
|
||||
@@ -200,7 +201,7 @@ module.exports = function (module) {
|
||||
return;
|
||||
}
|
||||
|
||||
const randomIndex = Math.floor(Math.random() * data.members.length);
|
||||
const randomIndex = secureRandom(0, data.members.length - 1);
|
||||
const value = data.members[randomIndex];
|
||||
await module.setRemove(data._key, value);
|
||||
return value;
|
||||
|
||||
Reference in New Issue
Block a user