Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-21 15:03:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: deep clone activity prop before execution; feps.announce

Browse Source
This commit is contained in:
Julian Lam
2025-12-02 13:42:06 -05:00
parent 8236b594af
commit 977a67f4cd
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/activitypub/feps.js
View File

@@ -10,6 +10,8 @@ const activitypub = module.parent.exports;
const Feps = module.exports; const Feps = module.exports;
Feps.announce = async function announce(id, activity) { Feps.announce = async function announce(id, activity) {
activity = structuredClone(activity);
let localId; let localId;
if (String(id).startsWith(nconf.get('url'))) { if (String(id).startsWith(nconf.get('url'))) {
({ id: localId } = await activitypub.helpers.resolveLocalId(id)); ({ id: localId } = await activitypub.helpers.resolveLocalId(id));

3
test/activitypub/feps.js
View File

@@ -163,10 +163,8 @@ describe('FEPs', () => {
cc: [`${nconf.get('url')}/category/${cid}`], cc: [`${nconf.get('url')}/category/${cid}`],
}); });
pid = id; pid = id;
console.log('note passed to mocks.create', note);
({ activity } = await helpers.mocks.create(note)); ({ activity } = await helpers.mocks.create(note));
console.log('activity passed to inbox.create', activity);
await activitypub.inbox.create({ body: activity }); await activitypub.inbox.create({ body: activity });
const activities = Array.from(activitypub._sent); const activities = Array.from(activitypub._sent);
@@ -183,7 +181,6 @@ describe('FEPs', () => {
return activity.type === 'Announce' && return activity.type === 'Announce' &&
activity.object && activity.object.type === 'Note'; activity.object && activity.object.type === 'Note';
}); });
console.log('activities', JSON.stringify(activities, null, 2));
assert(test1 && test2); assert(test1 && test2);
}); });