refactor: remove admin.themes.getInstalled

socket call, and just load the themes in the api call

src/controllers/admin/appearance.js

@@ -1,9 +1,12 @@
 'use strict';
 
+const meta = require('../../meta');
+
 const appearanceController = module.exports;
 
-appearanceController.themes = function (req, res) {
-	res.render(`admin/appearance/themes`, {});
+appearanceController.themes = async function (req, res) {
+	const themes = await meta.themes.get();
+	res.render(`admin/appearance/themes`, { themes });
 };
 
 appearanceController.skins = function (req, res) {

src/privileges/admin.js

@@ -115,7 +115,6 @@ privsAdmin.socketMap = {
 	'admin.getSearchDict': 'admin:settings',
 	'admin.config.setMultiple': 'admin:settings',
 	'admin.config.remove': 'admin:settings',
-	'admin.themes.getInstalled': 'admin:settings',
 	'admin.themes.set': 'admin:settings',
 	'admin.reloadAllSessions': 'admin:settings',
 	'admin.settings.get': 'admin:settings',

src/socket.io/admin/themes.js

@@ -5,10 +5,6 @@ const widgets = require('../../widgets');
 
 const Themes = module.exports;
 
-Themes.getInstalled = async function () {
-	return await meta.themes.get();
-};
-
 Themes.set = async function (socket, data) {
 	if (!data) {
 		throw new Error('[[error:invalid-data]]');

src/views/admin/appearance/themes.tpl

@@ -10,7 +10,11 @@
 
 	<div id="themes" class="themes px-2">
 		<div class="directory row text-center" id="installed_themes">
-			<i class="fa fa-refresh fa-spin"></i> [[admin/appearance/themes:checking-for-installed]]
+			{{{ if themes.length }}}
+			<!-- IMPORT admin/partials/theme_list.tpl -->
+			{{{ else }}}
+			<div class="alert alert-info no-themes">[[admin/appearance/themes:no-themes]]</div>
+			{{{ end}}}
 		</div>
 	</div>
 </div>