From d959aad41f885526958382f801c932d9dbe9fe64 Mon Sep 17 00:00:00 2001 From: Richie Preece Date: Tue, 21 Jan 2014 20:56:12 -0700 Subject: [PATCH 01/23] Changed to bcrypt.js --- package.json | 4 ++-- src/login.js | 2 +- src/user.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index bbc04c94ac..8534d01908 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,6 @@ "passport-facebook": "0.1.5", "less-middleware": "0.1.12", "marked": "0.2.8", - "bcrypt": "0.7.5", "async": "~0.2.8", "node-imagemagick": "0.1.8", "gravatar": "1.0.6", @@ -47,7 +46,8 @@ "semver": "~2.2.1", "string": "~1.7.0", "xregexp": "~2.0.0", - "socket.io-wildcard": "~0.1.1" + "socket.io-wildcard": "~0.1.1", + "bcryptjs": "~0.7.10" }, "optionalDependencies": { "redis": "0.8.3", diff --git a/src/login.js b/src/login.js index c4eb226586..baa636d73a 100644 --- a/src/login.js +++ b/src/login.js @@ -1,5 +1,5 @@ var user = require('./user'), - bcrypt = require('bcrypt'), + bcrypt = require('bcryptjs'), db = require('./database'), path = require('path'), winston = require('winston'), diff --git a/src/user.js b/src/user.js index f9e6bc548a..10dd494b2f 100644 --- a/src/user.js +++ b/src/user.js @@ -1,4 +1,4 @@ -var bcrypt = require('bcrypt'), +var bcrypt = require('bcryptjs'), async = require('async'), nconf = require('nconf'), winston = require('winston'), From 2988230b073c81ee9d99c1a5822f4558bda89b7a Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sat, 25 Jan 2014 22:19:51 -0500 Subject: [PATCH 02/23] some more fixes, cant quote and see deleted messages --- public/src/forum/pagination.js | 11 ++++---- public/src/forum/topic.js | 47 ++++++++++++---------------------- src/socket.io/posts.js | 12 ++++++++- 3 files changed, 34 insertions(+), 36 deletions(-) diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js index 3a95d250af..66db32c959 100644 --- a/public/src/forum/pagination.js +++ b/public/src/forum/pagination.js @@ -14,11 +14,11 @@ define(function() { $('.pagination') .on('click', '.previous', function() { - pagination.loadPage(pagination.currentPage - 1); + return pagination.loadPage(pagination.currentPage - 1); }).on('click', '.next', function() { - pagination.loadPage(pagination.currentPage + 1); + return pagination.loadPage(pagination.currentPage + 1); }).on('click', '.page', function() { - pagination.loadPage($(this).attr('data-page')); + return pagination.loadPage($(this).attr('data-page')); }).on('click', '.select_page', function(e) { e.preventDefault(); bootbox.prompt('Enter page number:', function(pageNum) { @@ -58,7 +58,7 @@ define(function() { for(var i=0; i 0) { if (pagesToShow[i] - 1 !== pagesToShow[i-1]) { - html += '
  • |
    • '; + html += '
  • |
    • '; } } html += '
  • ' + pagesToShow[i] + '
    • '; @@ -72,10 +72,11 @@ define(function() { pagination.loadPage = function(page, callback) { page = parseInt(page, 10); if(!utils.isNumber(page) || page < 1 || page > pagination.pageCount) { - return; + return false; } ajaxify.go(window.location.pathname.slice(1) + '?page=' + page); + return true; } function updatePageLinks() { diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js index d83b62218f..99de78753f 100644 --- a/public/src/forum/topic.js +++ b/public/src/forum/topic.js @@ -396,7 +396,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { socket.emit('posts.getRawPost', pid, function(err, post) { if(err) { - return app.alert(err.message); + return app.alertError(err.message); } var quoted = ''; if(post) { @@ -895,47 +895,34 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { } function toggle_post_delete_state(pid) { - var postEl = $(document.querySelector('#post-container li[data-pid="' + pid + '"]')); + var postEl = $('#post-container li[data-pid="' + pid + '"]'); - if (postEl[0]) { - quoteEl = postEl.find('.quote'), - favEl = postEl.find('.favourite'), - replyEl = postEl.find('.post_reply'); + if (postEl.length) { + postEl.toggleClass('deleted'); - socket.emit('posts.getPrivileges', pid, function(err, privileges) { - if(err) { - return app.alert(err.message); - } + toggle_post_tools(pid, postEl.hasClass('deleted')); - if (privileges.editable) { - if (!postEl.hasClass('deleted')) { - toggle_post_tools(pid, false); - } else { - toggle_post_tools(pid, true); - } - } - - postEl.toggleClass('deleted'); - - updatePostCount(); - }); + updatePostCount(); } } - function toggle_post_tools(pid, state) { - var postEl = $(document.querySelector('#post-container li[data-pid="' + pid + '"]')), + function toggle_post_tools(pid, isDeleted) { + var postEl = $('#post-container li[data-pid="' + pid + '"]'), quoteEl = $(postEl[0].querySelector('.quote')), favEl = $(postEl[0].querySelector('.favourite')), - replyEl = $(postEl[0].querySelector('.post_reply')); + replyEl = $(postEl[0].querySelector('.post_reply')), + chatEl = $(postEl[0].querySelector('.chat')); - if (state) { - quoteEl.removeClass('none'); - favEl.removeClass('none'); - replyEl.removeClass('none'); - } else { + if (isDeleted) { quoteEl.addClass('none'); favEl.addClass('none'); replyEl.addClass('none'); + chatEl.addClass('none'); + } else { + quoteEl.removeClass('none'); + favEl.removeClass('none'); + replyEl.removeClass('none'); + chatEl.removeClass('none'); } } diff --git a/src/socket.io/posts.js b/src/socket.io/posts.js index 14726ab0cb..cf5c05a444 100644 --- a/src/socket.io/posts.js +++ b/src/socket.io/posts.js @@ -93,7 +93,17 @@ SocketPosts.uploadFile = function(socket, data, callback) { }; SocketPosts.getRawPost = function(socket, pid, callback) { - posts.getPostField(pid, 'content', callback); + posts.getPostFields(pid, ['content', 'deleted'], function(err, data) { + if(err) { + return callback(err); + } + + if(data.deleted === '1') { + return callback(new Error('This post no longer exists')); + } + + callback(null, data.content); + }); }; SocketPosts.edit = function(socket, data, callback) { From 810095d287da8351f7824ec35b5685f7188c2b1b Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sat, 25 Jan 2014 22:30:48 -0500 Subject: [PATCH 03/23] fixed infinite loading on categories --- public/src/forum/category.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/src/forum/category.js b/public/src/forum/category.js index 62c6e0f59f..bcc636a839 100644 --- a/public/src/forum/category.js +++ b/public/src/forum/category.js @@ -48,7 +48,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { var bottom = ($(document).height() - $(window).height()) * 0.9; if ($(window).scrollTop() > bottom && !loadingMoreTopics) { - Category.loadMoreTopics(cid); + Category.loadMoreTopics(templates.get('category_id')); } }); } else { From bd0b5f4cdb8801a702d6c9567ad8a90a8d0d3b57 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sat, 25 Jan 2014 22:43:49 -0500 Subject: [PATCH 04/23] more error checks in thread move --- src/threadTools.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/threadTools.js b/src/threadTools.js index 076c9b4b0b..201cf7afe8 100644 --- a/src/threadTools.js +++ b/src/threadTools.js @@ -187,9 +187,20 @@ var winston = require('winston'), ThreadTools.move = function(tid, cid, callback) { topics.getTopicFields(tid, ['cid', 'lastposttime'], function(err, topicData) { + if(err) { + return callback(err); + } + var oldCid = topicData.cid; + if(!oldCid) { + return callback(new Error('invalid-topic')); + } db.sortedSetRemove('categories:' + oldCid + ':tid', tid, function(err, result) { + if(err) { + return callback(err); + } + db.sortedSetAdd('categories:' + cid + ':tid', topicData.lastposttime, tid, function(err, result) { if(err) { From 14e68bc9e2c07bfff87ab446f8804689ee366edb Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 01:34:40 -0500 Subject: [PATCH 05/23] dropup for bottom post bar --- public/templates/topic.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl index 39688723d8..7ee6f547c8 100644 --- a/public/templates/topic.tpl +++ b/public/templates/topic.tpl @@ -186,7 +186,7 @@ -
    +
    • [[topic:thread_tools.markAsUnreadForAll]]
      • From d7d4290099c3c0438110cdd625723acf7b5ec4cc Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Sun, 26 Jan 2014 13:10:39 -0500 Subject: [PATCH 06/23] resolved #879 --- src/plugins.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/plugins.js b/src/plugins.js index 375616c414..9b7257204b 100644 --- a/src/plugins.js +++ b/src/plugins.js @@ -202,6 +202,10 @@ var fs = require('fs'), } else return; }; + Plugins.hasListeners = function(hook, callback) { + return Plugins.loadedHooks[hook].length > 0; + }; + Plugins.fireHook = function(hook, args, callback) { hookList = Plugins.loadedHooks[hook]; From 96b2a1529038b4818d5c76f3c0211fcca6e0777b Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Sun, 26 Jan 2014 13:21:23 -0500 Subject: [PATCH 07/23] user registration now no longer sends a welcome email if no emailers are present --- src/plugins.js | 4 ++-- src/user.js | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/plugins.js b/src/plugins.js index 9b7257204b..5f1bd0d4e2 100644 --- a/src/plugins.js +++ b/src/plugins.js @@ -202,8 +202,8 @@ var fs = require('fs'), } else return; }; - Plugins.hasListeners = function(hook, callback) { - return Plugins.loadedHooks[hook].length > 0; + Plugins.hasListeners = function(hook) { + return (Plugins.loadedHooks[hook] && Plugins.loadedHooks[hook].length > 0); }; Plugins.fireHook = function(hook, args, callback) { diff --git a/src/user.js b/src/user.js index 4728f4b824..4ddfa25f16 100644 --- a/src/user.js +++ b/src/user.js @@ -886,6 +886,10 @@ var bcrypt = require('bcrypt'), User.email = { verify: function(uid, email) { + if (!plugins.hasListeners('action:email.send')) { + return; + } + var confirm_code = utils.generateUUID(), confirm_link = nconf.get('url') + '/confirm/' + confirm_code; From c6d48f477c0ea03db52a8b8b08d27138b079fac3 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 14:03:33 -0500 Subject: [PATCH 08/23] fixes recent topic post notification --- public/src/forum/recent.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/public/src/forum/recent.js b/public/src/forum/recent.js index 8e0eaeb293..10c8968417 100644 --- a/public/src/forum/recent.js +++ b/public/src/forum/recent.js @@ -38,10 +38,8 @@ define(function() { }); socket.on('event:new_topic', function(data) { - ++Recent.newTopicCount; Recent.updateAlertText(); - }); socket.on('event:new_post', function(data) { @@ -61,16 +59,16 @@ define(function() { Recent.updateAlertText = function() { var text = 'There'; - if (newTopicCount > 1) { - text += ' are ' + newTopicCount + ' new topics'; - } else if (newTopicCount === 1) { + if (Recent.newTopicCount > 1) { + text += ' are ' + Recent.newTopicCount + ' new topics'; + } else if (Recent.newTopicCount === 1) { text += ' is a new topic'; } - if (newPostCount > 1) { - text += (newTopicCount?' and ':' are ') + newPostCount + ' new posts'; + if (Recent.newPostCount > 1) { + text += (Recent.newTopicCount?' and ':' are ') + Recent.newPostCount + ' new posts'; } else if(newPostCount === 1) { - text += (newTopicCount?' and ':' is ') + ' a new post'; + text += (Recent.newTopicCount?' and ':' is ') + ' a new post'; } text += '. Click here to reload.'; From 2560704839875e30d9cc4d01999ec6ac030227b5 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 14:56:16 -0500 Subject: [PATCH 09/23] recent unread cleanup --- public/src/app.js | 10 ++++ public/src/forum/category.js | 6 +- public/src/forum/recent.js | 104 +++++++++++++++++++---------------- public/src/forum/topic.js | 6 +- public/src/forum/unread.js | 90 +++++------------------------- 5 files changed, 85 insertions(+), 131 deletions(-) diff --git a/public/src/app.js b/public/src/app.js index 3f9f33e152..21c0c72c86 100644 --- a/public/src/app.js +++ b/public/src/app.js @@ -396,6 +396,16 @@ var socket, }); }; + app.enableInfiniteLoading = function(callback) { + $(window).off('scroll').on('scroll', function() { + var bottom = ($(document).height() - $(window).height()) * 0.9; + + if ($(window).scrollTop() > bottom) { + callback(); + } + }); + } + var titleObj = { active: false, interval: undefined, diff --git a/public/src/forum/category.js b/public/src/forum/category.js index bcc636a839..29dcffa269 100644 --- a/public/src/forum/category.js +++ b/public/src/forum/category.js @@ -44,10 +44,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { function enableInfiniteLoading() { if(!config.usePagination) { - $(window).off('scroll').on('scroll', function (ev) { - var bottom = ($(document).height() - $(window).height()) * 0.9; - - if ($(window).scrollTop() > bottom && !loadingMoreTopics) { + app.enableInfiniteLoading(function() { + if(!loadingMoreTopics) { Category.loadMoreTopics(templates.get('category_id')); } }); diff --git a/public/src/forum/recent.js b/public/src/forum/recent.js index 10c8968417..966ce0058d 100644 --- a/public/src/forum/recent.js +++ b/public/src/forum/recent.js @@ -1,20 +1,16 @@ define(function() { var Recent = {}; - Recent.newTopicCount = 0; - Recent.newPostCount = 0; - Recent.loadingMoreTopics = false; + var newTopicCount = 0, + newPostCount = 0, + loadingMoreTopics = false; var active = ''; Recent.init = function() { app.enterRoom('recent_posts'); - ajaxify.register_events([ - 'event:new_topic', - 'event:new_post' - ]); - + Recent.watchForNewPosts(); function getActiveSection() { var url = window.location.href, @@ -37,65 +33,58 @@ define(function() { $(this).addClass('hide'); }); - socket.on('event:new_topic', function(data) { - ++Recent.newTopicCount; - Recent.updateAlertText(); - }); - socket.on('event:new_post', function(data) { - ++Recent.newPostCount; - Recent.updateAlertText(); - }); - - $(window).off('scroll').on('scroll', function() { - var bottom = ($(document).height() - $(window).height()) * 0.9; - - if ($(window).scrollTop() > bottom && !Recent.loadingMoreTopics) { + app.enableInfiniteLoading(function() { + if(!loadingMoreTopics) { Recent.loadMoreTopics(); } }); }; + Recent.watchForNewPosts = function () { + + newPostCount = 0; + newTopicCount = 0; + + ajaxify.register_events([ + 'event:new_topic', + 'event:new_post' + ]); + + socket.on('event:new_topic', function(data) { + ++newTopicCount; + Recent.updateAlertText(); + }); + + socket.on('event:new_post', function(data) { + ++newPostCount; + Recent.updateAlertText(); + }); + } + Recent.updateAlertText = function() { var text = 'There'; - if (Recent.newTopicCount > 1) { - text += ' are ' + Recent.newTopicCount + ' new topics'; - } else if (Recent.newTopicCount === 1) { + if (newTopicCount > 1) { + text += ' are ' + newTopicCount + ' new topics'; + } else if (newTopicCount === 1) { text += ' is a new topic'; } - if (Recent.newPostCount > 1) { - text += (Recent.newTopicCount?' and ':' are ') + Recent.newPostCount + ' new posts'; + if (newPostCount > 1) { + text += (newTopicCount?' and ':' are ') + newPostCount + ' new posts'; } else if(newPostCount === 1) { - text += (Recent.newTopicCount?' and ':' is ') + ' a new post'; + text += (newTopicCount?' and ':' is ') + ' a new post'; } text += '. Click here to reload.'; $('#new-topics-alert').html(text).removeClass('hide').fadeIn('slow'); - } - - Recent.onTopicsLoaded = function(topics) { - var html = templates.prepare(templates['recent'].blocks['topics']).parse({ - topics: topics - }); - - translator.translate(html, function(translatedHTML) { - var container = $('#topics-container'); - - $('#category-no-topics').remove(); - - html = $(translatedHTML); - container.append(html); - $('span.timeago').timeago(); - app.createUserTooltips(); - app.makeNumbersHumanReadable(html.find('.human-readable-number')); - }); + $('#category-no-topics').addClass('hide'); } Recent.loadMoreTopics = function() { - Recent.loadingMoreTopics = true; + loadingMoreTopics = true; socket.emit('topics.loadMoreRecentTopics', { after: $('#topics-container').children('li').length, term: active @@ -103,10 +92,29 @@ define(function() { if(err) { return app.alertError(err.message); } + if (data.topics && data.topics.length) { - Recent.onTopicsLoaded(data.topics); + Recent.onTopicsLoaded('recent', data.topics); } - Recent.loadingMoreTopics = false; + + loadingMoreTopics = false; + }); + } + + Recent.onTopicsLoaded = function(template, topics) { + var html = templates.prepare(templates[template].blocks['topics']).parse({ + topics: topics + }); + + translator.translate(html, function(translatedHTML) { + + $('#category-no-topics').remove(); + + html = $(translatedHTML); + $('#topics-container').append(html); + $('span.timeago').timeago(); + app.createUserTooltips(); + app.makeNumbersHumanReadable(html.find('.human-readable-number')); }); } diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js index 99de78753f..518ea3d64b 100644 --- a/public/src/forum/topic.js +++ b/public/src/forum/topic.js @@ -346,10 +346,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { function enableInfiniteLoading() { if(!config.usePagination) { - $(window).off('scroll').on('scroll', function() { - var bottom = ($(document).height() - $(window).height()) * 0.9; - - if ($(window).scrollTop() > bottom && !infiniteLoaderActive && $('#post-container').children().length) { + app.enableInfiniteLoading(function() { + if (!infiniteLoaderActive && $('#post-container').children().length) { loadMorePosts(tid, function(posts) { fixDeleteStateForPosts(); }); diff --git a/public/src/forum/unread.js b/public/src/forum/unread.js index abd19067de..b562ce1502 100644 --- a/public/src/forum/unread.js +++ b/public/src/forum/unread.js @@ -1,53 +1,15 @@ -define(function() { +define(['forum/recent'], function(recent) { var Unread = {}, loadingMoreTopics = false; Unread.init = function() { app.enterRoom('recent_posts'); - ajaxify.register_events([ - 'event:new_topic', - 'event:new_post', - 'topics.markAllRead' - ]); - - var newTopicCount = 0, - newPostCount = 0; - $('#new-topics-alert').on('click', function() { $(this).addClass('hide'); }); - socket.on('event:new_topic', function(data) { - ++newTopicCount; - updateAlertText(); - }); - - function updateAlertText() { - var text = 'There'; - - if (newTopicCount > 1) { - text += ' are ' + newTopicCount + ' new topics'; - } else if (newTopicCount === 1) { - text += ' is a new topic'; - } - - if (newPostCount > 1) { - text += (newTopicCount?' and ':' are ') + newPostCount + ' new posts'; - } else if(newPostCount === 1) { - text += (newTopicCount?' and ':' is ') + ' a new post'; - } - - text += '. Click here to reload.'; - - $('#new-topics-alert').html(text).removeClass('hide').fadeIn('slow'); - $('#category-no-topics').addClass('hidden'); - } - - socket.on('event:new_post', function(data) { - ++newPostCount; - updateAlertText(); - }); + recent.watchForNewPosts(); $('#mark-allread-btn').on('click', function() { var btn = $(this); @@ -67,25 +29,20 @@ define(function() { }); }); - function onTopicsLoaded(topics) { - - var html = templates.prepare(templates['unread'].blocks['topics']).parse({ - topics: topics - }); - - translator.translate(html, function(translatedHTML) { - var container = $('#topics-container'); - - $('#category-no-topics').remove(); - - html = $(translatedHTML); - container.append(html); - $('span.timeago').timeago(); - app.createUserTooltips(); - app.makeNumbersHumanReadable(html.find('.human-readable-number')); - }); + if ($("body").height() <= $(window).height() && $('#topics-container').children().length >= 20) { + $('#load-more-btn').show(); } + $('#load-more-btn').on('click', function() { + loadMoreTopics(); + }); + + app.enableInfiniteLoading(function() { + if(!loadingMoreTopics) { + loadMoreTopics(); + } + }); + function loadMoreTopics() { loadingMoreTopics = true; socket.emit('topics.loadMoreUnreadTopics', { @@ -96,7 +53,7 @@ define(function() { } if (data.topics && data.topics.length) { - onTopicsLoaded(data.topics); + recent.onTopicsLoaded('unread', data.topics); $('#topics-container').attr('data-next-start', data.nextStart); } else { $('#load-more-btn').hide(); @@ -105,23 +62,6 @@ define(function() { loadingMoreTopics = false; }); } - - $(window).off('scroll').on('scroll', function() { - var bottom = ($(document).height() - $(window).height()) * 0.9; - - if ($(window).scrollTop() > bottom && !loadingMoreTopics) { - loadMoreTopics(); - } - }); - - - if ($("body").height() <= $(window).height() && $('#topics-container').children().length >= 20) { - $('#load-more-btn').show(); - } - - $('#load-more-btn').on('click', function() { - loadMoreTopics(); - }); }; return Unread; From 22354227be7f710ebf0b93d303f72b717ad980c9 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Sun, 26 Jan 2014 15:59:22 -0500 Subject: [PATCH 10/23] hiding "Forgot Password" link using Plugins.hasListeners, instead of derpy config settings bool --- public/src/forum/login.js | 6 ------ public/templates/login.tpl | 5 ++++- src/routes/api.js | 11 ++++++----- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/public/src/forum/login.js b/public/src/forum/login.js index 9dca615a75..563db9d64e 100644 --- a/public/src/forum/login.js +++ b/public/src/forum/login.js @@ -52,12 +52,6 @@ define(function() { }); document.querySelector('#content input').focus(); - - if(!config.emailSetup) - $('#reset-link').addClass('hide'); - else - $('#reset-link').removeClass('hide'); - }; return Login; diff --git a/public/templates/login.tpl b/public/templates/login.tpl index 1557a6c2e3..8f7807421d 100644 --- a/public/templates/login.tpl +++ b/public/templates/login.tpl @@ -41,7 +41,10 @@
      -   [[login:forgot_password]] + + +   [[login:forgot_password]] +
      diff --git a/src/routes/api.js b/src/routes/api.js index 6dbb0080f7..08d4107f74 100644 --- a/src/routes/api.js +++ b/src/routes/api.js @@ -11,10 +11,11 @@ var path = require('path'), posts = require('../posts'), categories = require('../categories'), categoryTools = require('../categoryTools') + meta = require('../meta'), + Plugins = require('../plugins'), utils = require('../../public/src/utils'), translator = require('../../public/src/translator'), - pkg = require('../../package.json'), - meta = require('../meta'); + pkg = require('../../package.json'); (function (Api) { @@ -46,7 +47,6 @@ var path = require('path'), config.topicsPerPage = meta.config.topicsPerPage || 20; config.postsPerPage = meta.config.postsPerPage || 20; config.maximumFileSize = meta.config.maximumFileSize; - config.emailSetup = !!meta.config['email:from']; config.defaultLang = meta.config.defaultLang || 'en'; res.json(200, config); @@ -116,7 +116,8 @@ var path = require('path'), app.get('/login', function (req, res) { var data = {}, login_strategies = auth.get_login_strategies(), - num_strategies = login_strategies.length; + num_strategies = login_strategies.length, + emailersPresent = Plugins.hasListeners('action:email.send'); if (num_strategies == 0) { data = { @@ -131,8 +132,8 @@ var path = require('path'), } data.authentication = login_strategies; - data.token = res.locals.csrf_token; + data.showResetLink = emailersPresent; res.json(data); }); From 0c71707fb5bb52196a367c440da8ee930d80e051 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Sun, 26 Jan 2014 16:22:50 -0500 Subject: [PATCH 11/23] fixed #877 --- public/src/forum/topic.js | 6 +++--- src/socket.io/topics.js | 16 +++++++++++----- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js index 518ea3d64b..b241c9cc5e 100644 --- a/public/src/forum/topic.js +++ b/public/src/forum/topic.js @@ -1097,7 +1097,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { var insertAfter = findInsertionPoint(); - parseAndTranslatePosts(data.posts, function(translatedHTML) { + parseAndTranslatePosts(data, function(translatedHTML) { var translated = $(translatedHTML); if(!infiniteLoaded) { @@ -1112,8 +1112,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { }); } - function parseAndTranslatePosts(posts, callback) { - var html = templates.prepare(templates['topic'].blocks['posts']).parse({posts: posts}); + function parseAndTranslatePosts(data, callback) { + var html = templates.prepare(templates['topic'].blocks['posts']).parse(data); var regexp = new RegExp("([\\s\\S]*?)", 'g'); html = html.replace(regexp, ''); diff --git a/src/socket.io/topics.js b/src/socket.io/topics.js index 6ea39afbc9..b81b484610 100644 --- a/src/socket.io/topics.js +++ b/src/socket.io/topics.js @@ -1,6 +1,9 @@ var topics = require('../topics'), threadTools = require('../threadTools'), index = require('./index'), + + async = require('async'), + SocketTopics = {}; SocketTopics.post = function(socket, data, callback) { @@ -236,12 +239,15 @@ SocketTopics.loadMore = function(socket, data, callback) { var start = data.after, end = start + postsPerPage - 1; - topics.getTopicPosts(data.tid, start, end, socket.uid, function(err, posts) { - if(err) { - return callback(err); + async.parallel({ + posts: function(next) { + topics.getTopicPosts(data.tid, start, end, socket.uid, next); + }, + privileges: function(next) { + threadTools.privileges(data.tid, socket.uid, next); } - - callback(err, {posts: posts}); + }, function(err, results) { + callback(err, results); }); }; From da626a4035d6a5130954bde7c021642c715c5e0a Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 16:23:37 -0500 Subject: [PATCH 12/23] more fixes --- src/database/mongo.js | 17 +++++++++++++++++ src/database/redis.js | 4 ++++ src/routes/api.js | 2 +- src/topics.js | 26 +++++++++++++++++++------- 4 files changed, 41 insertions(+), 8 deletions(-) diff --git a/src/database/mongo.js b/src/database/mongo.js index 59fbc41b5a..9ebc45bd33 100644 --- a/src/database/mongo.js +++ b/src/database/mongo.js @@ -656,6 +656,23 @@ }); } + module.sortedSetRevRank = function(key, value, callback) { + if(value !== null && value !== undefined) { + value = value.toString(); + } + module.getSortedSetRange(key, 0, -1, function(err, result) { + if(err) { + return callback(err); + } + var rank = result.indexOf(value); + if(rank === -1) { + return callback(null, null); + } + + callback(null, result.length - rank - 1); + }); + } + module.sortedSetScore = function(key, value, callback) { if(value !== null && value !== undefined) { value = value.toString(); diff --git a/src/database/redis.js b/src/database/redis.js index de4802456c..b4e67b836b 100644 --- a/src/database/redis.js +++ b/src/database/redis.js @@ -382,6 +382,10 @@ redisClient.zrank(key, value, callback); } + module.sortedSetRevRank = function(key, value, callback) { + redisClient.zrevrank(key, value, callback); + } + module.sortedSetScore = function(key, value, callback) { redisClient.zscore(key, value, callback); } diff --git a/src/routes/api.js b/src/routes/api.js index 6dbb0080f7..58b818668d 100644 --- a/src/routes/api.js +++ b/src/routes/api.js @@ -245,7 +245,7 @@ var path = require('path'), app.get('/recent/:term?', function (req, res, next) { var uid = (req.user) ? req.user.uid : 0; - topics.getLatestTopics(uid, 0, 19, req.params.term, function (err, data) { + topics.getLatestTopics(uid, 0, 9, req.params.term, function (err, data) { if(err) { return next(err); } diff --git a/src/topics.js b/src/topics.js index d7848ce466..76a98767d9 100644 --- a/src/topics.js +++ b/src/topics.js @@ -426,8 +426,9 @@ var async = require('async'), }; var since = terms['day']; - if(terms[term]) + if(terms[term]) { since = terms[term]; + } var args = ['topics:recent', '+inf', timestamp - since, 'LIMIT', start, end - start + 1]; db.getSortedSetRevRangeByScore(args, function(err, tids) { @@ -442,11 +443,9 @@ var async = require('async'), if (!tids || !tids.length) { latestTopics.no_topics_message = 'show'; - callback(err, latestTopics); - return; + return callback(null, latestTopics); } - // Filter out topics that belong to categories that this user cannot access async.filter(tids, function(tid, next) { threadTools.privileges(tid, current_user, function(err, privileges) { if (!err && privileges.read) { @@ -457,8 +456,20 @@ var async = require('async'), }); }, function(tids) { Topics.getTopicsByTids(tids, 0, current_user, function(err, topicData) { - latestTopics.topics = topicData; - callback(err, latestTopics); + if(err) { + return callback(err); + } + + if(!topicData || !topicData.length) { + latestTopics.no_topics_message = 'show'; + return callback(null, latestTopics); + } + + db.sortedSetRevRank('topics:recent', topicData[topicData.length - 1].tid, function(err, rank) { + latestTopics.lastIndex = rank; + latestTopics.topics = topicData; + callback(null, latestTopics); + }); }); }); }); @@ -700,6 +711,7 @@ var async = require('async'), function isTopicVisible(topicData, topicInfo) { var deleted = parseInt(topicData.deleted, 10) !== 0; + return !deleted || (deleted && topicInfo.privileges.view_deleted) || topicData.uid === current_user; } @@ -738,7 +750,7 @@ var async = require('async'), if (isTopicVisible(topicData, topicInfo)) { retrieved_topics.push(topicData); - } + } else console.log('not visible'); next(null); }); From 45a5b888248de651f7cebd96882a9ce81f6039f8 Mon Sep 17 00:00:00 2001 From: psychobunny Date: Sun, 26 Jan 2014 16:50:59 -0500 Subject: [PATCH 13/23] added filter:messaging.parse hook --- src/messaging.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/messaging.js b/src/messaging.js index af3b8a1183..152c12c063 100644 --- a/src/messaging.js +++ b/src/messaging.js @@ -97,7 +97,19 @@ var db = require('./database'), username = ' ' + toUserData.username + ': '; } - callback(picture + username + parsed); + var messageData = { + message: message, + parsed: parsed, + fromuid: fromuid, + myuid: myuid, + toUserData: toUserData, + myUserData: myUserData, + parsedMessage: picture + username + parsed + }; + + plugins.fireHook('filter:messaging.parse', messageData, function(err, messageData) { + callback(messageData.parsedMessage); + }); }); }; From 25442a89caf6749b0e159654bdac5cfca226a7c0 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 17:17:34 -0500 Subject: [PATCH 14/23] closes #878 --- public/src/forum/category.js | 3 +- public/src/forum/recent.js | 3 +- public/src/forum/unread.js | 4 +- public/templates/category.tpl | 2 +- public/templates/recent.tpl | 2 +- public/templates/unread.tpl | 2 +- src/categories.js | 70 ++++++++++++++++++++--------------- src/socket.io/categories.js | 10 ++--- src/socket.io/topics.js | 6 +-- src/topics.js | 35 ++++++++++-------- tests/categories.js | 6 +-- 11 files changed, 77 insertions(+), 66 deletions(-) diff --git a/public/src/forum/category.js b/public/src/forum/category.js index 29dcffa269..e61443337b 100644 --- a/public/src/forum/category.js +++ b/public/src/forum/category.js @@ -145,7 +145,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { loadingMoreTopics = true; socket.emit('categories.loadMore', { cid: cid, - after: $('#topics-container').children('.category-item').length + after: $('#topics-container').attr('data-nextstart') }, function (err, data) { if(err) { return app.alertError(err.message); @@ -153,6 +153,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) { if (data && data.topics.length) { Category.onTopicsLoaded(data.topics); + $('#topics-container').attr('data-nextstart', data.nextStart); } loadingMoreTopics = false; }); diff --git a/public/src/forum/recent.js b/public/src/forum/recent.js index 966ce0058d..17d4602403 100644 --- a/public/src/forum/recent.js +++ b/public/src/forum/recent.js @@ -86,7 +86,7 @@ define(function() { Recent.loadMoreTopics = function() { loadingMoreTopics = true; socket.emit('topics.loadMoreRecentTopics', { - after: $('#topics-container').children('li').length, + after: $('#topics-container').attr('data-nextstart'), term: active }, function(err, data) { if(err) { @@ -95,6 +95,7 @@ define(function() { if (data.topics && data.topics.length) { Recent.onTopicsLoaded('recent', data.topics); + $('#topics-container').attr('data-nextstart', data.nextStart); } loadingMoreTopics = false; diff --git a/public/src/forum/unread.js b/public/src/forum/unread.js index b562ce1502..4f3024fbab 100644 --- a/public/src/forum/unread.js +++ b/public/src/forum/unread.js @@ -46,7 +46,7 @@ define(['forum/recent'], function(recent) { function loadMoreTopics() { loadingMoreTopics = true; socket.emit('topics.loadMoreUnreadTopics', { - after: parseInt($('#topics-container').attr('data-next-start'), 10) + after: $('#topics-container').attr('data-nextstart') }, function(err, data) { if(err) { return app.alertError(err.message); @@ -54,7 +54,7 @@ define(['forum/recent'], function(recent) { if (data.topics && data.topics.length) { recent.onTopicsLoaded('unread', data.topics); - $('#topics-container').attr('data-next-start', data.nextStart); + $('#topics-container').attr('data-nextstart', data.nextStart); } else { $('#load-more-btn').hide(); } diff --git a/public/templates/category.tpl b/public/templates/category.tpl index 5b578dc604..a8b73e765c 100644 --- a/public/templates/category.tpl +++ b/public/templates/category.tpl @@ -28,7 +28,7 @@
      -
        +
        • diff --git a/public/templates/recent.tpl b/public/templates/recent.tpl index 71ce3054d7..27fbf7ad94 100644 --- a/public/templates/recent.tpl +++ b/public/templates/recent.tpl @@ -21,7 +21,7 @@
          -
            +
            • diff --git a/public/templates/unread.tpl b/public/templates/unread.tpl index 114e8cba83..36874fd2b8 100644 --- a/public/templates/unread.tpl +++ b/public/templates/unread.tpl @@ -16,7 +16,7 @@
              -
                +
                • diff --git a/src/categories.js b/src/categories.js index a2aee70091..31e425c27b 100644 --- a/src/categories.js +++ b/src/categories.js @@ -1,8 +1,8 @@ -var db = require('./database.js'), - posts = require('./posts.js'), - utils = require('./../public/src/utils.js'), - user = require('./user.js'), - topics = require('./topics.js'), +var db = require('./database'), + posts = require('./posts'), + utils = require('./../public/src/utils'), + user = require('./user'), + topics = require('./topics'), plugins = require('./plugins'), CategoryTools = require('./categoryTools'), meta = require('./meta'), @@ -52,8 +52,8 @@ var db = require('./database.js'), return callback(err); } - function getTopicIds(next) { - Categories.getTopicIds(category_id, start, end, next); + function getTopics(next) { + Categories.getCategoryTopics(category_id, start, end, current_user, next); } function getActiveUsers(next) { @@ -70,9 +70,12 @@ var db = require('./database.js'), Categories.getPageCount(category_id, next); } - async.parallel([getTopicIds, getActiveUsers, getSidebars, getPageCount], function(err, results) { - var tids = results[0], - active_users = results[1], + async.parallel([getTopics, getActiveUsers, getSidebars, getPageCount], function(err, results) { + if(err) { + return callback(err); + } + + var active_users = results[1], sidebars = results[2], pageCount = results[3]; @@ -87,27 +90,22 @@ var db = require('./database.js'), 'topic_row_size': 'col-md-9', 'category_id': category_id, 'active_users': [], - 'topics': [], + 'topics': results[0].topics, + 'nextStart': results[0].nextStart, 'pageCount': pageCount, 'disableSocialButtons': meta.config.disableSocialButtons !== undefined ? parseInt(meta.config.disableSocialButtons, 10) !== 0 : false, 'sidebars': sidebars }; - function getTopics(next) { - topics.getTopicsByTids(tids, category_id, current_user, next); - } - function getModerators(next) { Categories.getModerators(category_id, next); } function getActiveUsers(next) { - user.getMultipleUserFields(active_users, ['uid', 'username', 'userslug', 'picture'], function(err, users) { - next(err, users); - }); + user.getMultipleUserFields(active_users, ['uid', 'username', 'userslug', 'picture'], next); } - if (tids.length === 0) { + if (!category.topics.length) { getModerators(function(err, moderators) { category.moderator_block_class = moderators.length > 0 ? '' : 'none'; category.moderators = moderators; @@ -116,11 +114,10 @@ var db = require('./database.js'), callback(null, category); }); } else { - async.parallel([getTopics, getModerators, getActiveUsers], function(err, results) { - category.topics = results[0]; - category.moderator_block_class = results[1].length > 0 ? '' : 'none'; - category.moderators = results[1]; - category.active_users = results[2]; + async.parallel([getModerators, getActiveUsers], function(err, results) { + category.moderator_block_class = results[0].length > 0 ? '' : 'none'; + category.moderators = results[0]; + category.active_users = results[1]; category.show_sidebar = category.topics.length > 0 ? 'show' : 'hidden'; callback(null, category); }); @@ -131,13 +128,26 @@ var db = require('./database.js'), }; Categories.getCategoryTopics = function(cid, start, stop, uid, callback) { - Categories.getTopicIds(cid, start, stop, function(err, tids) { - if(err) { - return callback(err); - } + async.waterfall([ + function(next) { + Categories.getTopicIds(cid, start, stop, next); + }, + function(tids, next) { + topics.getTopicsByTids(tids, cid, uid, next); + }, + function(topics, next) { + db.sortedSetRevRank('categories:' + cid + ':tid', topics[topics.length - 1].tid, function(err, rank) { + if(err) { + return next(err); + } - topics.getTopicsByTids(tids, cid, uid, callback); - }); + return next(null, { + topics: topics, + nextStart: parseInt(rank, 10) + 1 + }); + }); + } + ], callback); }; Categories.getTopicIds = function(cid, start, stop, callback) { diff --git a/src/socket.io/categories.js b/src/socket.io/categories.js index eaac85b4ac..4ccc949779 100644 --- a/src/socket.io/categories.js +++ b/src/socket.io/categories.js @@ -18,14 +18,10 @@ SocketCategories.loadMore = function(socket, data, callback) { var topicsPerPage = parseInt(meta.config.topicsPerPage, 10) || 20; - var start = data.after, + var start = parseInt(data.after, 10), end = start + topicsPerPage - 1; - - categories.getCategoryTopics(data.cid, start, end, socket.uid, function(err, topics) { - callback(err, { - topics: topics - }); - }); +console.log(start, end); + categories.getCategoryTopics(data.cid, start, end, socket.uid, callback); }; SocketCategories.getPageCount = function(socket, cid, callback) { diff --git a/src/socket.io/topics.js b/src/socket.io/topics.js index b81b484610..e290efc59e 100644 --- a/src/socket.io/topics.js +++ b/src/socket.io/topics.js @@ -236,7 +236,7 @@ SocketTopics.loadMore = function(socket, data, callback) { var postsPerPage = parseInt(meta.config.postsPerPage, 10); postsPerPage = postsPerPage ? postsPerPage : 20; - var start = data.after, + var start = parseInt(data.after, 10), end = start + postsPerPage - 1; async.parallel({ @@ -256,14 +256,14 @@ SocketTopics.loadMoreRecentTopics = function(socket, data, callback) { return callback(new Error('invalid data')); } - var start = data.after, + var start = parseInt(data.after, 10), end = start + 9; topics.getLatestTopics(socket.uid, start, end, data.term, callback); }; SocketTopics.loadMoreUnreadTopics = function(socket, data, callback) { - var start = data.after, + var start = parseInt(data.after, 10), end = start + 9; topics.getUnreadTopics(socket.uid, start, end, callback); diff --git a/src/topics.js b/src/topics.js index 76a98767d9..580b1e15d3 100644 --- a/src/topics.js +++ b/src/topics.js @@ -448,11 +448,7 @@ var async = require('async'), async.filter(tids, function(tid, next) { threadTools.privileges(tid, current_user, function(err, privileges) { - if (!err && privileges.read) { - next(true); - } else { - next(false); - } + next(!err && privileges.read); }); }, function(tids) { Topics.getTopicsByTids(tids, 0, current_user, function(err, topicData) { @@ -466,7 +462,7 @@ var async = require('async'), } db.sortedSetRevRank('topics:recent', topicData[topicData.length - 1].tid, function(err, rank) { - latestTopics.lastIndex = rank; + latestTopics.nextStart = parseInt(rank,10) + 1; latestTopics.topics = topicData; callback(null, latestTopics); }); @@ -549,7 +545,7 @@ var async = require('async'), return parseInt(read[index], 10) === 0; }); - // Filter out topics that belong to categories that this user cannot access + async.filter(newtids, function(tid, next) { threadTools.privileges(tid, uid, function(err, privileges) { if (!err && privileges.read) { @@ -599,16 +595,23 @@ var async = require('async'), return callback(err); } - unreadTopics.topics = topicData; - unreadTopics.nextStart = stop + 1; - if (!topicData || topicData.length === 0) { - unreadTopics.no_topics_message = 'show'; - } - if (uid === 0 || topicData.length === 0) { - unreadTopics.show_markallread_button = 'hidden'; - } + db.sortedSetRevRank('topics:recent', topicData[topicData.length - 1].tid, function(err, rank) { + if(err) { + return callback(err); + } - callback(null, unreadTopics); + unreadTopics.topics = topicData; + unreadTopics.nextStart = parseInt(rank, 10) + 1; + + if (!topicData || topicData.length === 0) { + unreadTopics.no_topics_message = 'show'; + } + if (uid === 0 || topicData.length === 0) { + unreadTopics.show_markallread_button = 'hidden'; + } + + callback(null, unreadTopics); + }); }); } diff --git a/tests/categories.js b/tests/categories.js index ba9cf3b702..770ad0b498 100644 --- a/tests/categories.js +++ b/tests/categories.js @@ -43,9 +43,9 @@ describe('Categories', function() { describe('.getCategoryTopics', function() { it('should return a list of topics', function(done) { - Categories.getCategoryTopics(categoryObj.cid, 0, 10, 0, function(err, topics) { - assert(Array.isArray(topics)); - assert(topics.every(function(topic) { + Categories.getCategoryTopics(categoryObj.cid, 0, 10, 0, function(err, result) { + assert(Array.isArray(result.topics)); + assert(result.topics.every(function(topic) { return topic instanceof Object; })); From 877028466175e4a4667dbef7b1013f4e90b56c75 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 17:23:28 -0500 Subject: [PATCH 15/23] removed console.log --- src/socket.io/categories.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/socket.io/categories.js b/src/socket.io/categories.js index 4ccc949779..ddea33d2f3 100644 --- a/src/socket.io/categories.js +++ b/src/socket.io/categories.js @@ -20,7 +20,7 @@ SocketCategories.loadMore = function(socket, data, callback) { var start = parseInt(data.after, 10), end = start + topicsPerPage - 1; -console.log(start, end); + categories.getCategoryTopics(data.cid, start, end, socket.uid, callback); }; From 25c4648e2eb433bb00b4e26e6b1f7d6a1113ec6a Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 17:25:18 -0500 Subject: [PATCH 16/23] load 20 in recent --- src/routes/api.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/api.js b/src/routes/api.js index e2ed523160..08d4107f74 100644 --- a/src/routes/api.js +++ b/src/routes/api.js @@ -246,7 +246,7 @@ var path = require('path'), app.get('/recent/:term?', function (req, res, next) { var uid = (req.user) ? req.user.uid : 0; - topics.getLatestTopics(uid, 0, 9, req.params.term, function (err, data) { + topics.getLatestTopics(uid, 0, 19, req.params.term, function (err, data) { if(err) { return next(err); } From 26673d3ada9e0be42e35a802cb2952ba133dc2a5 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 17:55:51 -0500 Subject: [PATCH 17/23] delegated events in admin categories --- public/src/forum/admin/categories.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/public/src/forum/admin/categories.js b/public/src/forum/admin/categories.js index 327e29968f..6142cafb24 100644 --- a/public/src/forum/admin/categories.js +++ b/public/src/forum/admin/categories.js @@ -178,13 +178,13 @@ define(['uploader'], function(uploader) { }); // Permissions modal - $('.permissions').on('click', function() { + $('.admin-categories').on('click', '.permissions', function() { var cid = $(this).parents('li[data-cid]').attr('data-cid'); Categories.launchPermissionsModal(cid); }); - $('.upload-button').on('click', function() { + $('.admin-categories').on('click', '.upload-button', function() { var inputEl = this; var cid = $(this).parents('li[data-cid]').attr('data-cid'); uploader.open(RELATIVE_PATH + '/admin/category/uploadpicture', {cid:cid}, function(imageUrlOnServer) { @@ -196,7 +196,7 @@ define(['uploader'], function(uploader) { }); }); - $('.admin-categories').delegate('.delete-image', 'click', function() { + $('.admin-categories').on('click', '.delete-image', function() { var parent = $(this).parents('li[data-cid]'), inputEl = parent.find('.upload-button'), preview = parent.find('.preview-box'), From c0e818afc617347237597193a1cc43fd8eff50f0 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 18:36:07 -0500 Subject: [PATCH 18/23] closes #854 --- public/src/forum/search.js | 6 +- public/templates/search.tpl | 106 +++++++++++++++++++++++------------- 2 files changed, 71 insertions(+), 41 deletions(-) diff --git a/public/src/forum/search.js b/public/src/forum/search.js index 17c65866a6..9ae2543b28 100644 --- a/public/src/forum/search.js +++ b/public/src/forum/search.js @@ -2,9 +2,9 @@ define(function() { var Search = {}; Search.init = function() { - var searchQuery = $('#topics-container').attr('data-search-query'); - - $('.search-result-text').each(function() { + var searchQuery = $('#topic-results').attr('data-search-query'); +console.log(searchQuery); + $('.search-result-text').children().each(function() { var text = $(this).html(); var regex = new RegExp(searchQuery, 'gi'); text = text.replace(regex, '' + searchQuery + ''); diff --git a/public/templates/search.tpl b/public/templates/search.tpl index 4eb5e44f2e..ebc4fdbd69 100644 --- a/public/templates/search.tpl +++ b/public/templates/search.tpl @@ -13,56 +13,86 @@
                  -
                  -
                  -

                  [[topic:topics]]

                  +
                  +
                  - - {topic_matches} result(s) matching "{search_query}" - -
                  [[topic:no_topics_found]]
                  +
                  -
                  +
                  -
                +
              -

              Posts

              - - {post_matches} result(s) matching "{search_query}" - -
              No posts found!
              +
              +

              Posts

              + + + {post_matches} result(s) matching "{search_query}" + +
              No posts found!
              -
              +
              -
            +
      From fb8fbb2372c5f290ffb6ac8c4faaf855becf45bf Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 18:40:28 -0500 Subject: [PATCH 19/23] removed console.log --- src/topics.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/topics.js b/src/topics.js index 580b1e15d3..b832817f88 100644 --- a/src/topics.js +++ b/src/topics.js @@ -753,7 +753,7 @@ var async = require('async'), if (isTopicVisible(topicData, topicInfo)) { retrieved_topics.push(topicData); - } else console.log('not visible'); + } next(null); }); From d54e2fba9ec0afc58f40fcc1b34905f95099d125 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 21:32:53 -0500 Subject: [PATCH 20/23] closes #810 --- public/src/forum/admin/index.js | 24 +++++++++++++++------- src/routes/debug.js | 10 ++++----- src/socket.io/index.js | 36 +++++++++++++-------------------- src/socket.io/meta.js | 16 ++------------- 4 files changed, 38 insertions(+), 48 deletions(-) diff --git a/public/src/forum/admin/index.js b/public/src/forum/admin/index.js index c0806106dd..c99dd43cb9 100644 --- a/public/src/forum/admin/index.js +++ b/public/src/forum/admin/index.js @@ -18,6 +18,7 @@ define(function() { }; Admin.updateRoomUsage = function(err, data) { + function getUserCountIn(room) { var count = 0; for(var user in data[room]) { @@ -25,27 +26,36 @@ define(function() { } return count; } - var active_users = $('#active_users'), + + var active_users = $('#active_users').html(''), total = 0; if(!active_users.length) { return; } - active_users.html(''); - var usersHtml = ''; + var sortedData = []; for (var room in data) { if (room !== '') { - var count = getUserCountIn(room); - total += count; - usersHtml += "
      " + room + " " + count + " active user" + (count > 1 ? "s" : "") + "
      "; + sortedData.push({room: room, count: data[room].length}); + total += data[room].length; } } + sortedData.sort(function(a, b) { + return parseInt(b.count, 10) - parseInt(a.count, 10); + }); + + var usersHtml = ''; + for(var i=0; i " + + sortedData[i].count + " active user" + (sortedData[i].count > 1 ? "s" : "") + "
      "; + } + active_users.html(usersHtml); - document.getElementById('connections').innerHTML = total; + $('#connections').html(total); }; return Admin; diff --git a/src/routes/debug.js b/src/routes/debug.js index b2a6e5c335..b25d00a894 100644 --- a/src/routes/debug.js +++ b/src/routes/debug.js @@ -75,12 +75,12 @@ var DebugRoute = function(app) { app.get('/test', function(req, res) { - /*topics.getTopicPosts2(2, 0, 10, 5, function(err, data) { - res.json(data); - })*/ - topics.getTopicWithPosts(2, 1, 0, -1, true, function (err, topicData) { - res.json(topicData); + var db = require('./../database'); + + db.getSortedSetRevRange('topics:recent', 0 , -1, function(err, tids) { + res.json(tids); }); + }); }); diff --git a/src/socket.io/index.js b/src/socket.io/index.js index 90ff00d7f3..a0d89bc102 100644 --- a/src/socket.io/index.js +++ b/src/socket.io/index.js @@ -22,12 +22,11 @@ var SocketIO = require('socket.io'), /* === */ -var users = {}, - io; + +var io; Sockets.userSockets = {}; -Sockets.rooms = {}; Sockets.init = function(server) { @@ -59,9 +58,9 @@ Sockets.init = function(server) { sessionID = socket.handshake.signedCookies["express.sid"]; db.sessionStore.get(sessionID, function(err, sessionData) { if (!err && sessionData && sessionData.passport && sessionData.passport.user) { - uid = users[sessionID] = sessionData.passport.user; + uid = sessionData.passport.user; } else { - uid = users[sessionID] = 0; + uid = 0; } socket.uid = parseInt(uid, 10); @@ -110,8 +109,8 @@ Sockets.init = function(server) { } if (Sockets.userSockets[uid] && Sockets.userSockets[uid].length === 0) { - delete users[sessionID]; delete Sockets.userSockets[uid]; + if (uid) { db.sortedSetRemove('users:online', uid, function(err, data) { }); @@ -126,17 +125,10 @@ Sockets.init = function(server) { emitOnlineUserCount(); - for (var roomName in Sockets.rooms) { - if (Sockets.rooms.hasOwnProperty(roomName)) { - socket.leave(roomName); - - if (Sockets.rooms[roomName][socket.id]) { - delete Sockets.rooms[roomName][socket.id]; - } - - updateRoomBrowsingText(roomName); - } + for(var roomName in io.sockets.manager.roomClients[socket.id]) { + updateRoomBrowsingText(roomName.slice(1)); } + }); socket.on('*', function(payload, callback) { @@ -222,9 +214,10 @@ function updateRoomBrowsingText(roomName) { function getUidsInRoom(room) { var uids = []; - for (var socketId in room) { - if (uids.indexOf(room[socketId]) === -1) { - uids.push(room[socketId]); + var clients = io.sockets.clients(roomName); + for(var i=0; i Date: Sun, 26 Jan 2014 22:10:06 -0500 Subject: [PATCH 21/23] chats - isNew flag, and sending in userData.uid now --- src/messaging.js | 8 ++++++-- src/socket.io/modules.js | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/messaging.js b/src/messaging.js index f6cc6671c0..6f2c54de28 100644 --- a/src/messaging.js +++ b/src/messaging.js @@ -56,13 +56,16 @@ var db = require('./database'), var messages = []; + userData[0].uid = touid; + userData[1].uid = fromuid; + function getMessage(mid, next) { db.getObject('message:' + mid, function(err, message) { if (err) { return next(err); } - Messaging.parse(message.content, message.fromuid, fromuid, userData[1], userData[0], function(result) { + Messaging.parse(message.content, message.fromuid, fromuid, userData[1], userData[0], false, function(result) { message.content = result; messages.push(message); next(null); @@ -81,7 +84,7 @@ var db = require('./database'), }); }; - Messaging.parse = function (message, fromuid, myuid, toUserData, myUserData, callback) { + Messaging.parse = function (message, fromuid, myuid, toUserData, myUserData, isNew, callback) { plugins.fireHook('filter:post.parse', message, function(err, parsed) { if (err) { return callback(message); @@ -104,6 +107,7 @@ var db = require('./database'), myuid: myuid, toUserData: toUserData, myUserData: myUserData, + isNew: isNew, parsedMessage: picture + username + parsed }; diff --git a/src/socket.io/modules.js b/src/socket.io/modules.js index d59a18425b..4a89b32ff4 100644 --- a/src/socket.io/modules.js +++ b/src/socket.io/modules.js @@ -109,7 +109,11 @@ SocketModules.chats.send = function(socket, data) { }); }); } - Messaging.parse(msg, socket.uid, socket.uid, usersData[1], usersData[0], function(parsed) { + + usersData[0].uid = socket.uid; + usersData[1].uid = touid; + + Messaging.parse(msg, socket.uid, socket.uid, usersData[1], usersData[0], true, function(parsed) { Messaging.addMessage(socket.uid, touid, msg, function(err, message) { var numSockets = 0, x; From 31a57cf0dd19af817a2622ee83193b84f99456f6 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 22:36:06 -0500 Subject: [PATCH 22/23] closes #885 --- public/src/utils.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/public/src/utils.js b/public/src/utils.js index e7916ef5f6..988253f3c1 100644 --- a/public/src/utils.js +++ b/public/src/utils.js @@ -106,6 +106,7 @@ collapseWhitespace : /\s+/g, collapseDash : /-+/g, trimTrailingDash : /-$/g, + trimLeadingDash : /^-/g, isLatin : /^[\w]+$/, //http://dense13.com/blog/2009/05/03/converting-string-to-slug-javascript/ @@ -120,6 +121,7 @@ str = str.replace(utils.collapseWhitespace, '-') str = str.replace(utils.collapseDash, '-'); str = str.replace(utils.trimTrailingDash, ''); + str = str.replace(utils.trimLeadingDash, ''); return str; }, From c18788fbc9c27f1451bf72a2c4732ab60bad8470 Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Sun, 26 Jan 2014 23:20:37 -0500 Subject: [PATCH 23/23] crash fix if topic has no posts, and check confirm obj --- src/feed.js | 10 +++++++--- src/user.js | 22 +++++++++++----------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/src/feed.js b/src/feed.js index 89828328e1..0b8fe46f49 100644 --- a/src/feed.js +++ b/src/feed.js @@ -38,13 +38,17 @@ } } + var description = topicData.posts.length ? topicData.posts[0].content : ''; + var image_url = topicData.posts.length ? topicData.posts[0].picture : ''; + var author = topicData.posts.length ? topicData.posts[0].username : ''; + var feed = new rss({ title: topicData.topic_name, - description: topicData.posts[0].content, + description: description, feed_url: Feed.defaults.baseUrl + '/topics/' + tid + '.rss', site_url: nconf.get('url') + '/topic/' + topicData.slug, - image_url: topicData.posts[0].picture, - author: topicData.posts[0].username, + image_url: image_url, + author: author, ttl: Feed.defaults.ttl }), dateStamp; diff --git a/src/user.js b/src/user.js index 4ae5e527dc..ffbf32a707 100644 --- a/src/user.js +++ b/src/user.js @@ -926,21 +926,21 @@ var bcrypt = require('bcryptjs'), confirm: function(code, callback) { db.getObject('confirm:' + code, function(err, confirmObj) { if (err) { - callback({ + return callback({ status:'error' }); - } else { - if (confirmObj.uid && confirmObj.email) { - db.setObjectField('email:confirmed', confirmObj.email, '1', function() { - callback({ - status: 'ok' - }); - }); - } else { + } + + if (confirmObj && confirmObj.uid && confirmObj.email) { + db.setObjectField('email:confirmed', confirmObj.email, '1', function() { callback({ - status: 'not_ok' + status: 'ok' }); - } + }); + } else { + callback({ + status: 'not_ok' + }); } }); }