Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-03 11:01:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: don't call getUids on every topic load

Browse Source 
only call if user is guest or spider and cid is -1
use .some instead of filtering entire array
This commit is contained in:
Barış Soner Uşaklı
2026-02-23 16:01:06 -05:00
parent bcfdbf7c97
commit 8a60d9c2bc
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/controllers/topics.js
View File

@@ -41,12 +41,10 @@ topicsController.get = async function getTopic(req, res, next) {
userPrivileges,
settings,
rssToken,
uids,
] = await Promise.all([
privileges.topics.get(tid, req.uid),
user.getSettings(req.uid),
user.auth.getFeedToken(req.uid),
topics.getUids(tid),
]);
let currentPage = parseInt(req.query.page, 10) || 1;
@@ -56,8 +54,7 @@ topicsController.get = async function getTopic(req, res, next) {
userPrivileges.disabled ||
invalidPagination ||
(topicData.scheduled && !userPrivileges.view_scheduled) ||
(!req.uid && (topicData.cid === -1 && !uids.filter(uid => utils.isNumber(uid)).length))
) {
await shouldHideTopicFromGuest(req.uid, tid, topicData.cid)) {
return next();
}
@@ -164,6 +161,12 @@ topicsController.get = async function getTopic(req, res, next) {
res.render('topic', topicData);
};
async function shouldHideTopicFromGuest(uid, tid, cid) {
if (uid > 0 || cid !== -1) return false;
const uids = await topics.getUids(tid);
return !uids.some(uid => utils.isNumber(uid));
}
function generateQueryString(query) {
const qString = qs.stringify(query);
return qString.length ? `?${qString}` : '';