From 64aa89f5eee9cd1bef57ea91a5f7bd01885a717f Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Wed, 5 Mar 2014 19:33:10 -0500
Subject: [PATCH 1/5] updating upgrade script to use UTC timestamps *facepalm*.
 God, I hope I didn't break anything...

(first pass #1155)
---
 src/upgrade.js | 46 +++++++++++++++++++++++-----------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/src/upgrade.js b/src/upgrade.js
index 0876aa7113..08b5594ab1 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -15,11 +15,11 @@ var db = require('./database'),
 
 	Upgrade = {},
 
-	minSchemaDate = new Date(2014, 0, 4).getTime(),		// This value gets updated every new MINOR version
+	minSchemaDate = Date.UTC(2014, 0, 4),		// This value gets updated every new MINOR version
 	schemaDate, thisSchemaDate,
 
 	// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema
-	latestSchema = new Date(2014, 1, 22).getTime();
+	latestSchema = Date.UTC(2014, 1, 22);
 
 Upgrade.check = function(callback) {
 	db.get('schemaDate', function(err, value) {
@@ -64,7 +64,7 @@ Upgrade.upgrade = function(callback) {
 			});
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 5).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 5);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -108,7 +108,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 5, 14, 6).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 5, 14, 6);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -257,7 +257,7 @@ Upgrade.upgrade = function(callback) {
 				});
 			}
 
-			thisSchemaDate = new Date(2014, 0, 7).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 7);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -277,7 +277,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 13, 12, 0).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 13, 12, 0);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -300,7 +300,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 19, 22, 19).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 19, 22, 19);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -318,7 +318,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 23, 16, 5).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 23, 16, 5);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -342,7 +342,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 25, 0, 0).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 25, 0, 0);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -377,7 +377,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 27, 12, 35).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 27, 12, 35);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -421,7 +421,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 30, 15, 0).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 30, 15, 0);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -446,7 +446,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 0, 30, 16, 0).getTime();
+			thisSchemaDate = Date.UTC(2014, 0, 30, 16, 0);
 
 			function updateTopic(tid, next) {
 				Topics.getTopicFields(tid, ['postcount', 'viewcount'], function(err, topicData) {
@@ -494,7 +494,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 2, 16, 0).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 2, 16, 0);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -532,7 +532,7 @@ Upgrade.upgrade = function(callback) {
 		},
 		function(next) {
 
-			thisSchemaDate = new Date(2014, 1, 7, 16, 0).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 7, 16, 0);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -577,7 +577,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 9, 20, 50).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 9, 20, 50);
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
 
@@ -596,7 +596,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 14, 20, 50).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 14, 20, 50);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -646,7 +646,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 14, 21, 50).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 14, 21, 50);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -702,7 +702,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 19, 18, 15).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 19, 18, 15);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -728,7 +728,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 20, 15, 30).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 20, 15, 30);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -767,7 +767,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 20, 16, 15).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 20, 16, 15);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -787,7 +787,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 20, 19, 45).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 20, 19, 45);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -813,7 +813,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 20, 20, 25).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 20, 20, 25);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;
@@ -830,7 +830,7 @@ Upgrade.upgrade = function(callback) {
 			}
 		},
 		function(next) {
-			thisSchemaDate = new Date(2014, 1, 22).getTime();
+			thisSchemaDate = Date.UTC(2014, 1, 22);
 
 			if (schemaDate < thisSchemaDate) {
 				updatesMade = true;

From 5f52ef5f01c7003088c645acdc6d6cebf9365dd5 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Wed, 5 Mar 2014 19:41:16 -0500
Subject: [PATCH 2/5] removed all 0.3.x related upgrade scripts, and updated
 minSchemaDate

---
 src/upgrade.js | 640 +------------------------------------------------
 1 file changed, 1 insertion(+), 639 deletions(-)

diff --git a/src/upgrade.js b/src/upgrade.js
index 08b5594ab1..51f75232d8 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -15,7 +15,7 @@ var db = require('./database'),
 
 	Upgrade = {},
 
-	minSchemaDate = Date.UTC(2014, 0, 4),		// This value gets updated every new MINOR version
+	minSchemaDate = Date.UTC(2014, 1, 14, 21, 50),		// This value gets updated every new MINOR version
 	schemaDate, thisSchemaDate,
 
 	// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema
@@ -63,644 +63,6 @@ Upgrade.upgrade = function(callback) {
 				}
 			});
 		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 5);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.getListRange('categories:cid', 0, -1, function(err, cids) {
-					if(err) {
-						return next(err);
-					}
-
-					var timestamp = Date.now();
-
-					function upgradeCategory(cid, next) {
-						db.getSetMembers('cid:' + cid + ':active_users', function(err, uids) {
-							if(err) {
-								return next(err);
-							}
-
-							db.delete('cid:' + cid + ':active_users', function(err) {
-								if(err) {
-									return next(err);
-								}
-
-								for(var i=0; i<uids.length; ++i) {
-									db.sortedSetAdd('cid:' + cid + ':active_users', timestamp, uids[i]);
-								}
-								next();
-							});
-						});
-					}
-
-					async.each(cids, upgradeCategory, function(err) {
-						if(err) {
-							return next(err);
-						}
-						winston.info('[2014/1/5] Upgraded categories active users');
-						next();
-					});
-				});
-			} else {
-				winston.info('[2014/1/5] categories active users skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 5, 14, 6);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				// Re-slugify all users
-				db.delete('userslug:uid', function(err) {
-					if (!err) {
-						db.getObjectValues('username:uid', function(err, uids) {
-							var	newUserSlug;
-
-							async.each(uids, function(uid, next) {
-								User.getUserField(uid, 'username', function(err, username) {
-									if(err) {
-										return next(err);
-									}
-									if(username) {
-										newUserSlug = Utils.slugify(username);
-										async.parallel([
-											function(next) {
-												User.setUserField(uid, 'userslug', newUserSlug, next);
-											},
-											function(next) {
-												db.setObjectField('userslug:uid', newUserSlug, uid, next);
-											}
-										], next);
-									} else {
-										winston.warn('uid '+ uid + ' doesn\'t have a valid username (' + username + '), skipping');
-										next(null);
-									}
-								});
-							}, function(err) {
-								winston.info('[2014/1/5] Re-slugify usernames (again)');
-								next(err);
-							});
-						});
-					}
-				});
-			} else {
-				winston.info('[2014/1/5] Re-slugify usernames (again) skipped');
-				next();
-			}
-		},
-		function(next) {
-			function upgradeUserPostsTopics(next) {
-
-				function upgradeUser(uid, next) {
-
-					function upgradeUserPosts(next) {
-
-						function addPostToUser(pid) {
-							Posts.getPostField(pid, 'timestamp', function(err, timestamp) {
-								db.sortedSetAdd('uid:' + uid + ':posts', timestamp, pid);
-							});
-						}
-
-						db.getListRange('uid:' + uid + ':posts', 0, -1, function(err, pids) {
-							if(err) {
-								return next(err);
-							}
-
-							if(!pids || !pids.length) {
-								return next();
-							}
-
-							db.delete('uid:' + uid + ':posts', function(err) {
-								for(var i = 0; i< pids.length; ++i)	{
-									addPostToUser(pids[i]);
-								}
-								next();
-							});
-						});
-					}
-
-					function upgradeUserTopics(next) {
-
-						function addTopicToUser(tid) {
-							Topics.getTopicField(tid, 'timestamp', function(err, timestamp) {
-								db.sortedSetAdd('uid:' + uid + ':topics', timestamp, tid);
-							});
-						}
-
-						db.getListRange('uid:' + uid + ':topics', 0, -1, function(err, tids) {
-							if(err) {
-								return next(err);
-							}
-
-							if(!tids || !tids.length) {
-								return next();
-							}
-
-							db.delete('uid:' + uid + ':topics', function(err) {
-								for(var i = 0; i< tids.length; ++i)	{
-									addTopicToUser(tids[i]);
-								}
-								next();
-							});
-						});
-					}
-
-					async.series([upgradeUserPosts, upgradeUserTopics], function(err, result) {
-						next(err);
-					});
-				}
-
-
-				db.getSortedSetRange('users:joindate', 0, -1, function(err, uids) {
-					if(err) {
-						return next(err);
-					}
-
-					async.each(uids, upgradeUser, function(err, result) {
-						next(err);
-					});
-				});
-			}
-
-			function upgradeTopicPosts(next) {
-				function upgradeTopic(tid, next) {
-					function addPostToTopic(pid) {
-						Posts.getPostField(pid, 'timestamp', function(err, timestamp) {
-							db.sortedSetAdd('tid:' + tid + ':posts', timestamp, pid);
-						});
-					}
-
-					db.getListRange('tid:' + tid + ':posts', 0, -1, function(err, pids) {
-						if(err) {
-							return next(err);
-						}
-
-						if(!pids || !pids.length) {
-							return next();
-						}
-
-						db.delete('tid:' + tid + ':posts', function(err) {
-							for(var i = 0; i< pids.length; ++i) {
-								addPostToTopic(pids[i]);
-							}
-							next();
-						});
-					});
-				}
-
-				db.getSetMembers('topics:tid', function(err, tids) {
-					async.each(tids, upgradeTopic, function(err, results) {
-						next(err);
-					});
-				});
-			}
-
-			thisSchemaDate = Date.UTC(2014, 0, 7);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				async.series([upgradeUserPostsTopics, upgradeTopicPosts], function(err, results) {
-					if(err) {
-						winston.err('Error upgrading '+ err.message);
-						return next(err);
-					}
-
-					winston.info('[2014/1/7] Updated topic and user posts to sorted set');
-					next();
-				});
-
-			} else {
-				winston.info('[2014/1/7] Update to topic and user posts to sorted set skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 13, 12, 0);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.getObjectValues('username:uid', function(err, uids) {
-					async.eachSeries(uids, function(uid, next) {
-						Groups.joinByGroupName('registered-users', uid, next);
-					}, function(err) {
-						if(err) {
-							winston.err('Error upgrading '+ err.message);
-							process.exit();
-						} else {
-							winston.info('[2014/1/13] Set up "Registered Users" user group');
-							next();
-						}
-					});
-				});
-			} else {
-				winston.info('[2014/1/13] Set up "Registered Users" user group - skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 19, 22, 19);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.getObjectValues('username:uid', function(err, uids) {
-					async.each(uids, function(uid, next) {
-						db.searchRemove('user', uid, next);
-					}, function(err) {
-						winston.info('[2014/1/19] Remove user search from Reds');
-						next();
-					});
-				});
-			} else {
-				winston.info('[2014/1/19] Remove user search from Reds -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 23, 16, 5);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				Groups.getByGroupName('Administrators', {}, function(err, groupObj) {
-					if (err && err.message === 'gid-not-found') {
-						winston.info('[2014/1/23] Updating Administrators Group -- skipped');
-						return next();
-					}
-
-					Groups.update(groupObj.gid, {
-						name: 'administrators',
-						hidden: '1'
-					}, function() {
-						winston.info('[2014/1/23] Updating Administrators Group');
-						next();
-					});
-				});
-			} else {
-				winston.info('[2014/1/23] Updating Administrators Group -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 25, 0, 0);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.getSortedSetRange('users:joindate', 0, -1, function(err, uids) {
-					if(err) {
-						return next(err);
-					}
-
-					if(!uids || !uids.length) {
-						winston.info('[2014/1/25] Updating User Gravatars to HTTPS  -- skipped');
-						return next();
-					}
-
-					var gravatar = require('gravatar');
-
-					function updateGravatar(uid, next) {
-						User.getUserFields(uid, ['email', 'picture', 'gravatarpicture'], function(err, userData) {
-							var gravatarPicture = User.createGravatarURLFromEmail(userData.email);
-							if(userData.picture === userData.gravatarpicture) {
-								User.setUserField(uid, 'picture', gravatarPicture);
-							}
-							User.setUserField(uid, 'gravatarpicture', gravatarPicture, next);
-						});
-					}
-
-					winston.info('[2014/1/25] Updating User Gravatars to HTTPS');
-					async.each(uids, updateGravatar, next);
-				});
-			} else {
-				winston.info('[2014/1/25] Updating User Gravatars to HTTPS -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 27, 12, 35);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				var	activations = [];
-
-				if (Meta.config['social:facebook:secret'] && Meta.config['social:facebook:app_id']) {
-					activations.push(function(next) {
-						Plugins.toggleActive('nodebb-plugin-sso-facebook', function(result) {
-							winston.info('[2014/1/25] Activating Facebook SSO Plugin');
-							next();
-						});
-					});
-				}
-				if (Meta.config['social:twitter:key'] && Meta.config['social:twitter:secret']) {
-					activations.push(function(next) {
-						Plugins.toggleActive('nodebb-plugin-sso-twitter', function(result) {
-							winston.info('[2014/1/25] Activating Twitter SSO Plugin');
-							next();
-						});
-					});
-				}
-				if (Meta.config['social:google:secret'] && Meta.config['social:google:id']) {
-					activations.push(function(next) {
-						Plugins.toggleActive('nodebb-plugin-sso-google', function(result) {
-							winston.info('[2014/1/25] Activating Google SSO Plugin');
-							next();
-						});
-					});
-				}
-
-				async.parallel(activations, function(err) {
-					if (!err) {
-						winston.info('[2014/1/25] Done activating SSO plugins');
-					}
-
-					next(err);
-				});
-			} else {
-				winston.info('[2014/1/25] Activating SSO plugins, if set up -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 30, 15, 0);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				if (Meta.config.defaultLang === 'en') {
-					Meta.configs.set('defaultLang', 'en_GB', next);
-				} else if (Meta.config.defaultLang === 'pt_br') {
-					Meta.configs.set('defaultLang', 'pt_BR', next);
-				} else if (Meta.config.defaultLang === 'zh_cn') {
-					Meta.configs.set('defaultLang', 'zh_CN', next);
-				} else if (Meta.config.defaultLang === 'zh_tw') {
-					Meta.configs.set('defaultLang', 'zh_TW', next);
-				} else {
-					winston.info('[2014/1/30] Fixing language settings -- skipped');
-					return next();
-				}
-
-				winston.info('[2014/1/30] Fixing language settings');
-				next();
-			} else {
-				winston.info('[2014/1/30] Fixing language settings -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 0, 30, 16, 0);
-
-			function updateTopic(tid, next) {
-				Topics.getTopicFields(tid, ['postcount', 'viewcount'], function(err, topicData) {
-					if(err) {
-						next(err);
-					}
-
-					if(topicData) {
-						if(!topicData.postcount) {
-							topicData.postcount = 0;
-						}
-
-						if(!topicData.viewcount) {
-							topicData.viewcount = 0;
-						}
-
-						db.sortedSetAdd('topics:posts', topicData.postcount, tid);
-						db.sortedSetAdd('topics:views', topicData.viewcount, tid);
-					}
-
-					next();
-				});
-			}
-
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-
-
-				winston.info('[2014/1/30] Adding new topic sets');
-				db.getSortedSetRange('topics:recent', 0, -1, function(err, tids) {
-					if(err) {
-						return next(err);
-					}
-
-					async.each(tids, updateTopic, function(err) {
-						next(err);
-					});
-				});
-
-
-			} else {
-				winston.info('[2014/1/30] Adding new topic sets -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 1, 2, 16, 0);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				winston.info('[2014/2/6] Upvoting all favourited posts for each user');
-
-				User.getUsers('users:joindate', 0, -1, function (err, users) {
-					function getFavourites(user, next) {
-						function upvote(post, next) {
-							var pid = post.pid,
-								uid = user.uid;
-
-							if (post.uid !== uid) {
-								db.setAdd('pid:' + pid + ':upvote', uid);
-								db.sortedSetAdd('uid:' + uid + ':upvote', post.timestamp, pid);
-								db.incrObjectField('post:' + pid, 'votes');
-							}
-
-							next();
-						}
-
-						Posts.getFavourites(user.uid, 0, -1, function(err, posts) {
-							async.each(posts.posts, upvote, function(err) {
-								next(err);
-							});
-						});
-					}
-					async.each(users, getFavourites, function(err) {
-						next(err);
-					});
-				});
-			} else {
-				winston.info('[2014/2/6] Upvoting all favourited posts for each user -- skipped');
-				next();
-			}
-		},
-		function(next) {
-
-			thisSchemaDate = Date.UTC(2014, 1, 7, 16, 0);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				winston.info('[2014/2/7] Updating category recent replies');
-				db.getListRange('categories:cid', 0, -1, function(err, cids) {
-
-					function updateCategory(cid, next) {
-						db.getSortedSetRevRange('categories:recent_posts:cid:' + cid, 0, - 1, function(err, pids) {
-							function updatePid(pid, next) {
-								Posts.getCidByPid(pid, function(err, realCid) {
-									if(err) {
-										return next(err);
-									}
-
-									if(parseInt(realCid, 10) !== parseInt(cid, 10)) {
-										Posts.getPostField(pid, 'timestamp', function(err, timestamp) {
-											db.sortedSetRemove('categories:recent_posts:cid:' + cid, pid);
-											db.sortedSetAdd('categories:recent_posts:cid:' + realCid, timestamp, pid);
-											next();
-										});
-									} else {
-										next();
-									}
-								});
-							}
-
-							async.each(pids, updatePid, next);
-						});
-					}
-
-					if(err) {
-						return next(err);
-					}
-
-					async.each(cids, updateCategory, next);
-				});
-
-
-			} else {
-				winston.info('[2014/2/7] Updating category recent replies -- skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 1, 9, 20, 50);
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.delete('tid:lastFeedUpdate', function(err) {
-					if(err) {
-						winston.err('Error upgrading '+ err.message);
-						process.exit();
-					} else {
-						winston.info('[2014/2/9] Remove Topic LastFeedUpdate value, as feeds are now on-demand');
-						next();
-					}
-				});
-			} else {
-				winston.info('[2014/2/9] Remove Topic LastFeedUpdate value, as feeds are now on-demand - skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 1, 14, 20, 50);
-
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.exists('topics:tid', function(err, exists) {
-					if(err) {
-						return next(err);
-					}
-
-					if(!exists) {
-						winston.info('[2014/2/14] Upgraded topics to sorted set - skipped');
-						return next();
-					}
-
-					db.getSetMembers('topics:tid', function(err, tids) {
-						if(err) {
-							return next(err);
-						}
-
-						if(!Array.isArray(tids)) {
-							winston.info('[2014/2/14] Upgraded topics to sorted set - skipped (cant find any tids)');
-							return next();
-						}
-
-						db.rename('topics:tid', 'topics:tid:old', function(err) {
-							if(err) {
-								return next(err);
-							}
-
-							async.each(tids, function(tid, next) {
-								Topics.getTopicField(tid, 'timestamp', function(err, timestamp) {
-									db.sortedSetAdd('topics:tid', timestamp, tid, next);
-								});
-							}, function(err) {
-								if(err) {
-									return next(err);
-								}
-								winston.info('[2014/2/14] Upgraded topics to sorted set');
-								db.delete('topics:tid:old', next);
-							});
-						});
-					});
-				});
-			} else {
-				winston.info('[2014/2/14] Upgrade topics to sorted set - skipped');
-				next();
-			}
-		},
-		function(next) {
-			thisSchemaDate = Date.UTC(2014, 1, 14, 21, 50);
-
-			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
-				db.exists('users:joindate', function(err, exists) {
-					if(err) {
-						return next(err);
-					}
-					if(!exists) {
-						winston.info('[2014/2/14] Added posts to sorted set - skipped');
-						return next();
-					}
-
-					db.getSortedSetRange('users:joindate', 0, -1, function(err, uids) {
-						if(err) {
-							return next(err);
-						}
-
-						if(!Array.isArray(uids)) {
-							winston.info('[2014/2/14] Add posts to sorted set - skipped (cant find any uids)');
-							return next();
-						}
-
-						async.each(uids, function(uid, next) {
-							User.getPostIds(uid, 0, -1, function(err, pids) {
-								if(err) {
-									return next(err);
-								}
-
-								async.each(pids, function(pid, next) {
-									Posts.getPostField(pid, 'timestamp', function(err, timestamp) {
-										if(err) {
-											return next(err);
-										}
-										db.sortedSetAdd('posts:pid', timestamp, pid, next);
-									});
-								}, next);
-							});
-						}, function(err) {
-							if(err) {
-								return next(err);
-							}
-
-							winston.info('[2014/2/14] Added posts to sorted set');
-							next();
-						});
-					});
-				});
-
-			} else {
-				winston.info('[2014/2/14] Added posts to sorted set - skipped');
-				next();
-			}
-		},
 		function(next) {
 			thisSchemaDate = Date.UTC(2014, 1, 19, 18, 15);
 

From b404b0197f4707c5682647778f20236dfdfad37e Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Wed, 5 Mar 2014 19:51:16 -0500
Subject: [PATCH 3/5] final pass, resolved #1155

---
 src/upgrade.js | 54 +++++++++++++++++++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 18 deletions(-)

diff --git a/src/upgrade.js b/src/upgrade.js
index 51f75232d8..9221d29cd0 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -38,6 +38,10 @@ Upgrade.check = function(callback) {
 	});
 };
 
+Upgrade.update = function(schemaDate, callback) {
+	db.set('schemaDate', schemaDate, callback);
+};
+
 Upgrade.upgrade = function(callback) {
 	var updatesMade = false;
 
@@ -67,8 +71,6 @@ Upgrade.upgrade = function(callback) {
 			thisSchemaDate = Date.UTC(2014, 1, 19, 18, 15);
 
 			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
 				db.setObjectField('widgets:home.tpl', 'motd', JSON.stringify([
 					{
 						"widget": "html",
@@ -82,7 +84,12 @@ Upgrade.upgrade = function(callback) {
 					Meta.configs.remove('show_motd');
 
 					winston.info('[2014/2/19] Updated MOTD to use the HTML widget.');
-					next(err);
+
+					if (err) {
+						next(err);
+					} else {
+						Upgrade.update(thisSchemaDate, next);
+					}
 				});
 			} else {
 				winston.info('[2014/2/19] Updating MOTD to use the HTML widget - skipped');
@@ -93,8 +100,6 @@ Upgrade.upgrade = function(callback) {
 			thisSchemaDate = Date.UTC(2014, 1, 20, 15, 30);
 
 			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
 				var container = '<div class="panel panel-default"><div class="panel-heading">{title}</div><div class="panel-body">{body}</div></div>';
 
 				db.setObjectField('widgets:category.tpl', 'sidebar', JSON.stringify([
@@ -121,7 +126,12 @@ Upgrade.upgrade = function(callback) {
 					}
 				]), function(err) {
 					winston.info('[2014/2/20] Adding Recent Replies, Active Users, and Moderator widgets to category sidebar.');
-					next(err);
+
+					if (err) {
+						next(err);
+					} else {
+						Upgrade.update(thisSchemaDate, next);
+					}
 				});
 			} else {
 				winston.info('[2014/2/20] Adding Recent Replies, Active Users, and Moderator widgets to category sidebar - skipped');
@@ -132,8 +142,6 @@ Upgrade.upgrade = function(callback) {
 			thisSchemaDate = Date.UTC(2014, 1, 20, 16, 15);
 
 			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
 				db.setObjectField('widgets:home.tpl', 'footer', JSON.stringify([
 					{
 						"widget": "forumstats",
@@ -141,7 +149,12 @@ Upgrade.upgrade = function(callback) {
 					}
 				]), function(err) {
 					winston.info('[2014/2/20] Adding Forum Stats Widget to the Homepage Footer.');
-					next(err);
+
+					if (err) {
+						next(err);
+					} else {
+						Upgrade.update(thisSchemaDate, next);
+					}
 				});
 			} else {
 				winston.info('[2014/2/20] Adding Forum Stats Widget to the Homepage Footer - skipped');
@@ -152,8 +165,6 @@ Upgrade.upgrade = function(callback) {
 			thisSchemaDate = Date.UTC(2014, 1, 20, 19, 45);
 
 			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
 				var container = '<div class="panel panel-default"><div class="panel-heading">{title}</div><div class="panel-body">{body}</div></div>';
 
 				db.setObjectField('widgets:home.tpl', 'sidebar', JSON.stringify([
@@ -167,7 +178,12 @@ Upgrade.upgrade = function(callback) {
 					}
 				]), function(err) {
 					winston.info('[2014/2/20] Updating Lavender MOTD');
-					next(err);
+
+					if (err) {
+						next(err);
+					} else {
+						Upgrade.update(thisSchemaDate, next);
+					}
 				});
 			} else {
 				winston.info('[2014/2/20] Updating Lavender MOTD - skipped');
@@ -178,8 +194,6 @@ Upgrade.upgrade = function(callback) {
 			thisSchemaDate = Date.UTC(2014, 1, 20, 20, 25);
 
 			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
 				db.setAdd('plugins:active', 'nodebb-widget-essentials', function(err) {
 					winston.info('[2014/2/20] Activating NodeBB Essential Widgets');
 					Plugins.reload(function() {
@@ -188,15 +202,18 @@ Upgrade.upgrade = function(callback) {
 				});
 			} else {
 				winston.info('[2014/2/20] Activating NodeBB Essential Widgets - skipped');
-				next();
+
+				if (err) {
+					next(err);
+				} else {
+					Upgrade.update(thisSchemaDate, next);
+				}
 			}
 		},
 		function(next) {
 			thisSchemaDate = Date.UTC(2014, 1, 22);
 
 			if (schemaDate < thisSchemaDate) {
-				updatesMade = true;
-
 				db.exists('categories:cid', function(err, exists) {
 					if(err) {
 						return next(err);
@@ -239,7 +256,8 @@ Upgrade.upgrade = function(callback) {
 									return next(err);
 								}
 								winston.info('[2014/2/22] Added categories to sorted set');
-								db.delete('categories:cid:old', next);
+								db.delete('categories:cid:old');
+								Upgrade.update(thisSchemaDate, next);
 							});
 						});
 					});

From 58cb51bb028d279d2338f00cb6dcdafaed8ad16e Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Wed, 5 Mar 2014 20:37:31 -0500
Subject: [PATCH 4/5] removed unused imagemagick require

---
 src/routes/user.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/routes/user.js b/src/routes/user.js
index 136473ce1b..641404f8a6 100644
--- a/src/routes/user.js
+++ b/src/routes/user.js
@@ -3,7 +3,6 @@ var fs = require('fs'),
 	winston = require('winston'),
 	nconf = require('nconf'),
 	async= require('async'),
-	imagemagick = require('node-imagemagick'),
 
 	user = require('./../user'),
 	posts = require('./../posts'),

From 096f352c82d107a0b137e48cdca8c32a3415bcff Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Wed, 5 Mar 2014 23:00:27 -0500
Subject: [PATCH 5/5] closes #1130

---
 package.json       |  2 +-
 src/image.js       | 36 ++++++++++++++----------------------
 src/routes/user.js |  4 ++++
 3 files changed, 19 insertions(+), 23 deletions(-)

diff --git a/package.json b/package.json
index 083db7f7a0..79d2d26c33 100644
--- a/package.json
+++ b/package.json
@@ -23,7 +23,7 @@
     "less-middleware": "0.1.12",
     "marked": "0.2.8",
     "async": "~0.2.8",
-    "node-imagemagick": "0.1.8",
+    "gm": "1.14.2",
     "gravatar": "1.0.6",
     "nconf": "~0.6.7",
     "sitemap": "~0.7.1",
diff --git a/src/image.js b/src/image.js
index 97bb237a16..5f92773fa8 100644
--- a/src/image.js
+++ b/src/image.js
@@ -1,6 +1,7 @@
+'use strict';
 
 var fs = require('fs'),
-	imagemagick = require('node-imagemagick'),
+	gm = require('gm').subClass({imageMagick: true}),
 	meta = require('./meta');
 
 var image = {};
@@ -11,35 +12,26 @@ image.resizeImage = function(path, extension, width, height, callback) {
 	}
 
 	if(extension === '.gif') {
-		imagemagick.convert([
-			path,
-			'-coalesce',
-			'-repage',
-			'0x0',
-			'-crop',
-			width+'x'+height+'+0+0',
-			'+repage',
-			path
-		], done);
+		gm().in(path)
+			.in('-coalesce')
+			.in('-resize')
+			.in(width+'x'+height)
+			.write(path, done);
 	} else {
-		imagemagick.crop({
-			srcPath: path,
-			dstPath: path,
-			width: width,
-			height: height
-		}, done);
+		gm(path)
+			.crop(width, height, 0, 0)
+			.write(path, done);
 	}
 };
 
 image.convertImageToPng = function(path, extension, callback) {
 	var convertToPNG = parseInt(meta.config['profile:convertProfileImageToPNG'], 10);
 	if(convertToPNG && extension !== '.png') {
-		imagemagick.convert([path, 'png:-'], function(err, stdout) {
-			if(err) {
+		gm(path).toBuffer('png', function(err, buffer) {
+			if (err) {
 				return callback(err);
 			}
-
-			fs.writeFile(path, stdout, 'binary', callback);
+			fs.writeFile(path, buffer, 'binary', callback);
 		});
 	} else {
 		callback();
@@ -50,6 +42,6 @@ image.convertImageToBase64 = function(path, callback) {
 	fs.readFile(path, function(err, data) {
 		callback(err, data ? data.toString('base64') : null);
 	});
-}
+};
 
 module.exports = image;
\ No newline at end of file
diff --git a/src/routes/user.js b/src/routes/user.js
index 641404f8a6..db25182b2a 100644
--- a/src/routes/user.js
+++ b/src/routes/user.js
@@ -116,6 +116,7 @@ var fs = require('fs'),
 
 				var uploadSize = parseInt(meta.config.maximumProfileImageSize, 10) || 256;
 				if (req.files.userPhoto.size > uploadSize * 1024) {
+					fs.unlink(req.files.userPhoto.path);
 					return res.send({
 						error: 'Images must be smaller than ' + uploadSize + ' kb!'
 					});
@@ -123,6 +124,7 @@ var fs = require('fs'),
 
 				var allowedTypes = ['image/png', 'image/jpeg', 'image/jpg', 'image/gif'];
 				if (allowedTypes.indexOf(req.files.userPhoto.type) === -1) {
+					fs.unlink(req.files.userPhoto.path);
 					return res.send({
 						error: 'Allowed image types are png, jpg and gif!'
 					});
@@ -130,6 +132,7 @@ var fs = require('fs'),
 
 				var extension = path.extname(req.files.userPhoto.name);
 				if (!extension) {
+					fs.unlink(req.files.userPhoto.path);
 					return res.send({
 						error: 'Error uploading file! Error : Invalid extension!'
 					});
@@ -184,6 +187,7 @@ var fs = require('fs'),
 					}
 
 					if(err) {
+						fs.unlink(req.files.userPhoto.path);
 						return res.send({error:err.message});
 					}