From 8895b152c2c53b2ca04c1e2d4d8f989c1dd92c64 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Mon, 25 Sep 2023 11:08:09 -0400
Subject: [PATCH] refactor: get rid of exists db call, use promise.parallel

---
 src/posts/create.js | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/posts/create.js b/src/posts/create.js
index ae9ebdbc85..b248f04a36 100644
--- a/src/posts/create.js
+++ b/src/posts/create.js
@@ -10,7 +10,6 @@ const topics = require('../topics');
 const categories = require('../categories');
 const groups = require('../groups');
 const privileges = require('../privileges');
-const utils = require('../utils');
 
 module.exports = function (Posts) {
 	Posts.create = async function (data) {
@@ -26,16 +25,7 @@ module.exports = function (Posts) {
 		}
 
 		if (data.toPid) {
-			const toPidExists = await Posts.exists(data.toPid);
-			const toPidDeleted = await Posts.getPostField(data.toPid, 'deleted');
-			const canViewToPid = await privileges.posts.can('posts:view_deleted', data.toPid, uid);
-
-			if (
-				!utils.isNumber(data.toPid) || !toPidExists ||
-				(toPidDeleted && !canViewToPid)
-			) {
-				throw new Error('[[error:invalid-pid]]');
-			}
+			await checkToPid(data.toPid);
 		}
 
 		const pid = await db.incrObjectField('global', 'nextPid');
@@ -90,4 +80,15 @@ module.exports = function (Posts) {
 			db.incrObjectField(`post:${postData.toPid}`, 'replies'),
 		]);
 	}
+
+	async function checkToPid(toPid, uid) {
+		const [toPost, canViewToPid] = await Promise.all([
+			Posts.getPostFields(toPid, ['pid', 'deleted']),
+			privileges.posts.can('posts:view_deleted', toPid, uid),
+		]);
+		const toPidExists = !!toPost.pid;
+		if (!toPidExists || (toPost.deleted && !canViewToPid)) {
+			throw new Error('[[error:invalid-pid]]');
+		}
+	}
 };