Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-05-06 18:37:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat: track user cids (#14114)

Browse Source 
* feat: start tracking which cids a user has posted to, update account pages' topics/posts view to call this new sorted set

re: #14113

* feat: upgrade script for #14113

* fix: cids unavailable in getPostsFields, duh

* fix: update sortedSetIncrByBulk in mongo/psql to return early on empty data

* fix: remove unused lodash require

* test: sortedSetIncrBy and sortedSetIncrByBulk tests

* test: who needs null checks anyway

* fix: sortedSetIncrByBulk null response

* test: aggregate zincrbulk data

if there are alot of identical key/value pairs they will be combined into a single row

* fix: key name

* test: fix test name

* lint: fix lint issues

* test: negative values should work too

* fix: add e11000 handler for incrByBulk

* refactor: fix variable name

* merge tests with existing zset test, remove dupes

* test: return topicData for failing test

* delete uid:<uid>:cids on user delete

---------

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
This commit is contained in:
Julian Lam
2026-03-26 10:30:28 -04:00
committed by GitHub
parent 74b702dfef
commit 781ed3447b
14 changed files with 189 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
test/database/sorted.js
View File

@@ -2,6 +2,7 @@
const assert = require('assert');
const db = require('../mocks/databasemock');
const utils = require('../../src/utils');
describe('Sorted Set methods', () => {
before(async () => {
@@ -1070,31 +1071,19 @@ NUMERIC)-- WsPn&query[cid]=-1&parentCid=0&selectedCids[]=-1&privilege=topics:rea
});
});
describe('sortedSetIncrBy()', () => {
it('should create a sorted set with a field set to 1', (done) => {
db.sortedSetIncrBy('sortedIncr', 1, 'field1', function (err, newValue) {
assert.equal(err, null);
assert.equal(arguments.length, 2);
assert.strictEqual(newValue, 1);
db.sortedSetScore('sortedIncr', 'field1', (err, score) => {
assert.equal(err, null);
assert.strictEqual(score, 1);
done();
});
});
describe('sortedSetIncrBy()/sortedSetIncrByBulk()', () => {
it('should create a sorted set with a field set to 1', async () => {
const newValue = await db.sortedSetIncrBy('sortedIncr', 1, 'field1');
assert.strictEqual(newValue, 1);
const score = await db.sortedSetScore('sortedIncr', 'field1');
assert.strictEqual(score, 1);
});
it('should increment a field of a sorted set by 5', (done) => {
db.sortedSetIncrBy('sortedIncr', 5, 'field1', function (err, newValue) {
assert.equal(err, null);
assert.equal(arguments.length, 2);
assert.strictEqual(newValue, 6);
db.sortedSetScore('sortedIncr', 'field1', (err, score) => {
assert.equal(err, null);
assert.strictEqual(score, 6);
done();
});
});
it('should increment a field of a sorted set by 5', async () => {
const newValue = await db.sortedSetIncrBy('sortedIncr', 5, 'field1');
assert.strictEqual(newValue, 6);
const score = await db.sortedSetScore('sortedIncr', 'field1');
assert.strictEqual(score, 6);
});
it('should increment fields of sorted sets with a single call', async () => {
@@ -1122,12 +1111,27 @@ NUMERIC)-- WsPn&query[cid]=-1&parentCid=0&selectedCids[]=-1&privilege=topics:rea
);
});
it('should increment the same zset twice', async () => {
const zset = utils.generateUUID();
const value1 = utils.generateUUID();
const value2 = utils.generateUUID();
await db.sortedSetIncrByBulk([
[zset, 1, value1],
[zset, 1, value2],
]);
const scores = await Promise.all([
db.sortedSetScore(zset, value1),
db.sortedSetScore(zset, value2),
]);
assert.deepStrictEqual(scores, [1, 1]);
});
it('should increment the same field', async () => {
const data1 = await db.sortedSetIncrByBulk([
await db.sortedSetIncrByBulk([
['sortedIncrBulk5', 5, 'value5'],
]);
const data2 = await db.sortedSetIncrByBulk([
await db.sortedSetIncrByBulk([
['sortedIncrBulk5', 5, 'value5'],
]);
assert.deepStrictEqual(
@@ -1137,6 +1141,41 @@ NUMERIC)-- WsPn&query[cid]=-1&parentCid=0&selectedCids[]=-1&privilege=topics:rea
],
);
});
it('should return empty array', async function () {
const zset = utils.generateUUID();
const response = await db.sortedSetIncrByBulk(zset, []);
assert(Array.isArray(response));
assert.strictEqual(response.length, 0);
});
it('should aggregate increments to the same key/value pair', async function () {
const zset = utils.generateUUID();
await db.sortedSetIncrByBulk([
[zset, 1, 'baz'],
[zset, 1, 'baz'],
[zset, 7, 'baz'],
[zset, 1, 'foo'],
[zset, 3, 'foo'],
[zset, 4, 'foo'],
[zset, 2, 'fizz'],
[zset, 1, 'fizz'],
[zset, -3, 'fizz'],
]);
const score = await db.sortedSetScores(zset, ['foo', 'baz', 'fizz']);
assert.deepStrictEqual(score, [8, 9, 0]);
});
it('should handle parallel increments with same key/value pairs', async function () {
const zset = utils.generateUUID();
await Promise.all([
db.sortedSetIncrByBulk([[zset, 1, 'baz']]),
db.sortedSetIncrByBulk([[zset, 1, 'baz']]),
db.sortedSetIncrByBulk([[zset, 1, 'baz']]),
]);
const score = await db.sortedSetScore(zset, 'baz');
assert.deepStrictEqual(score, 3);
});
});

7
test/topics.js
View File

@@ -1425,10 +1425,13 @@ describe('Topic\'s', () => {
const unreadTids = await topics.getUnreadTids({ cid: 0, uid: uid });
await sleep(2000);
const _unreadTids = await topics.getUnreadTids({ cid: 0, uid: uid });
const [_unreadTids, topicData] = await Promise.all([
topics.getUnreadTids({ cid: 0, uid: uid }),
topics.getTopicData(result.topicData.tid),
]);
assert(
!unreadTids.includes(result.topicData.tid),
JSON.stringify({ unreadTids, _unreadTids, tid: result.topicData.tid })
JSON.stringify({ unreadTids, _unreadTids, topic: topicData })
);
});
});