From 6fe066ced2707d31cac6e5ae911010aae08fbfbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 19 Mar 2025 21:03:08 -0400 Subject: [PATCH] fix: check if latestversion is valid before using semver.gt --- src/controllers/admin/dashboard.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/controllers/admin/dashboard.js b/src/controllers/admin/dashboard.js index d3bf019443..aa173eca07 100644 --- a/src/controllers/admin/dashboard.js +++ b/src/controllers/admin/dashboard.js @@ -28,12 +28,13 @@ dashboardController.get = async function (req, res) { getPopularSearches(), ]); const version = nconf.get('version'); + const latestValidVersion = semver.valid(latestVersion); res.render('admin/dashboard', { version: version, - lookupFailed: latestVersion === null, - latestVersion: latestVersion, - upgradeAvailable: latestVersion && semver.gt(latestVersion, version), + lookupFailed: latestValidVersion === null, + latestVersion: latestValidVersion, + upgradeAvailable: latestValidVersion && semver.gt(latestValidVersion, version), currentPrerelease: versions.isPrerelease.test(version), notices: notices, stats: stats,