From 6a1311b4bca99a35aa39858f0ff7782e4ee2cd42 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Fri, 8 Jan 2021 12:17:42 -0500
Subject: [PATCH] refactor: flags lib to have a separate getFlagIdsWithFilters
 method

added quick filter for unresolved flags
---
 src/flags.js | 29 +++++++++++++++++++++++++----
 1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/src/flags.js b/src/flags.js
index 8bf57257fd..e2c3085c6f 100644
--- a/src/flags.js
+++ b/src/flags.js
@@ -36,7 +36,11 @@ Flags.init = async function () {
 		if (!Array.isArray(value)) {
 			sets.push(prefix + value);
 		} else if (value.length) {
-			value.forEach(x => orSets.push(prefix + x));
+			if (value.length === 1) {
+				sets.push(prefix + value.pop());
+			} else {
+				value.forEach(x => orSets.push(prefix + x));
+			}
 		}
 	}
 
@@ -67,6 +71,10 @@ Flags.init = async function () {
 					case 'mine':
 						sets.push('flags:byAssignee:' + uid);
 						break;
+
+					case 'unresolved':
+						prepareSets(sets, orSets, 'flags:byState:', ['open', 'wip']);
+						break;
 				}
 			},
 		},
@@ -113,9 +121,13 @@ Flags.get = async function (flagId) {
 	return data.flag;
 };
 
-Flags.list = async function (data) {
-	const filters = data.filters || {};
+Flags.getCount = async function ({ uid, filters }) {
+	filters = filters || {};
+	const flagIds = await Flags.getFlagIdsWithFilters({ filters, uid });
+	return flagIds.length;
+};
 
+Flags.getFlagIdsWithFilters = async function ({ filters, uid }) {
 	let sets = [];
 	const orSets = [];
 
@@ -126,7 +138,7 @@ Flags.list = async function (data) {
 	for (var type in filters) {
 		if (filters.hasOwnProperty(type)) {
 			if (Flags._filters.hasOwnProperty(type)) {
-				Flags._filters[type](sets, orSets, filters[type], data.uid);
+				Flags._filters[type](sets, orSets, filters[type], uid);
 			} else {
 				winston.warn('[flags/list] No flag filter type found: ' + type);
 			}
@@ -152,6 +164,15 @@ Flags.list = async function (data) {
 		}
 	}
 
+	return flagIds;
+};
+
+Flags.list = async function (data) {
+	const filters = data.filters || {};
+	let flagIds = Flags.getFlagIdsWithFilters({
+		filters,
+		uid: data.uid,
+	});
 	flagIds = await Flags.sort(flagIds, data.sort);
 
 	// Create subset for parsing based on page number (n=20)