Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-03 11:01:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard against crash when malformed URL present in deliverees

Browse Source
This commit is contained in:
Julian Lam
2026-02-26 15:57:16 -05:00
parent f7d87ecbf9
commit 6a0663cdd0
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/activitypub/index.js
View File

@@ -135,11 +135,17 @@ ActivityPub.resolveInboxes = async (ids) => {
// Filter out blocked instances
const blocked = [];
inboxArr = inboxArr.filter((inbox) => {
const { hostname } = new URL(inbox);
const allowed = ActivityPub.instances.isAllowed(hostname);
if (!allowed) {
blocked.push(inbox);
let allowed = false;
try {
const { hostname } = new URL(inbox);
allowed = ActivityPub.instances.isAllowed(hostname);
if (!allowed) {
blocked.push(inbox);
}
} catch (e) {
winston.warn(`[activitypub/resolveInboxes] Malformed URL encountered while filtering out blocked instances: ${inbox}`);
}
return allowed;
});
if (blocked.length) {