Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-07-20 19:40:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Session Timeout if "Remember Me" is not checked (#11125)

Browse Source 
* fix: convert loginDays and loginSeconds to number inputs

* feat: configurable session timeout for when "Remember Me" is not checked

closes #11124

* test: addition tests to check loginDays and sessionDuration settings

* test: also test loginSeconds override
This commit is contained in:
Julian Lam
2023-01-05 14:10:02 -05:00
committed by GitHub
parent 2ea1510f8e
commit 69806662e6
5 changed files with 123 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/controllers/authentication.js
View File

@@ -294,8 +294,9 @@ function continueLogin(strategy, req, res, next) {
req.session.cookie.maxAge = duration;
req.session.cookie.expires = new Date(Date.now() + duration);
} else {
req.session.cookie.maxAge = false;
req.session.cookie.expires = false;
const duration = meta.config.sessionDuration * 1000;
req.session.cookie.maxAge = duration || false;
req.session.cookie.expires = duration ? new Date(Date.now() + duration) : false;
}
plugins.hooks.fire('action:login.continue', { req, strategy, userData, error: null });