From 641c8991f9055f5c44d7df76386abc4f36e10a52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Tue, 7 Apr 2015 12:52:48 -0400 Subject: [PATCH] closes #2944 if going to users page wait for updateOnlineUsers to complete --- src/middleware/middleware.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/middleware/middleware.js b/src/middleware/middleware.js index ced0f40674..6c03674483 100644 --- a/src/middleware/middleware.js +++ b/src/middleware/middleware.js @@ -48,14 +48,19 @@ middleware.applyCSRF = csrf(); middleware.ensureLoggedIn = ensureLoggedIn.ensureLoggedIn(nconf.get('relative_path') + '/login'); middleware.pageView = function(req, res, next) { - if (req.user) { - user.updateLastOnlineTime(req.user.uid); - user.updateOnlineUsers(req.user.uid); - } - analytics.pageView(req.ip); - next(); + if (req.user) { + user.updateLastOnlineTime(req.user.uid); + if (req.path.startsWith('/api/users') || req.path.startsWith('/users')) { + user.updateOnlineUsers(req.user.uid, next); + } else { + user.updateOnlineUsers(req.user.uid); + next(); + } + } else { + next(); + } }; middleware.redirectToAccountIfLoggedIn = function(req, res, next) {