Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-03 11:01:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: isHookValid

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2026-02-21 18:15:22 -05:00
parent a54083e341
commit 63c9a6e03c
1 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
src/plugins/hooks.js
View File

@@ -159,10 +159,7 @@ async function fireFilterHook(hook, hookList, params) {
}
async function fireMethod(hookObj, params) {
if (typeof hookObj.method !== 'function') {
if (process.env.NODE_ENV === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
if (!isHookValid(hook, hookObj)) {
return params;
}
@@ -184,21 +181,27 @@ async function fireActionHook(hook, hookList, params) {
return;
}
for (const hookObj of hookList) {
if (typeof hookObj.method !== 'function') {
if (process.env.NODE_ENV === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
} else {
try {
// eslint-disable-next-line
await hookObj.method(params);
} catch (err) {
winston.error(`[plugins] Error in hook ${hookObj.id}@${hookObj.hook} \n${err.stack}`);
}
if (!isHookValid(hook, hookObj)) {
continue;
}
try {
// eslint-disable-next-line
await hookObj.method(params);
} catch (err) {
winston.error(`[plugins] Error in hook ${hookObj.id}@${hookObj.hook} \n${err.stack}`);
}
}
}
function isHookValid(hook, hookObj) {
const isValid = typeof hookObj.method === 'function';
if (!isValid && process.env.NODE_ENV === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
return isValid;
}
// https://advancedweb.hu/how-to-add-timeout-to-a-promise-in-javascript/
const timeout = (prom, time, error) => {
let timer;
@@ -218,10 +221,7 @@ async function fireStaticHook(hook, hookList, params) {
const noErrorHooks = ['static:app.load', 'static:assets.prepare', 'static:app.preload'];
async function fireMethod(hookObj, params) {
if (typeof hookObj.method !== 'function') {
if (process.env.NODE_ENV === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
if (!isHookValid(hook, hookObj)) {
return params;
}
@@ -255,17 +255,16 @@ async function fireResponseHook(hook, hookList, params) {
return;
}
for (const hookObj of hookList) {
if (typeof hookObj.method !== 'function') {
if (process.env.NODE_ENV === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
} else {
// Skip remaining hooks if headers have been sent
if (params.res.headersSent) {
return;
}
// eslint-disable-next-line
await hookObj.method(params);
if (!isHookValid(hook, hookObj)) {
continue;
}
// Skip remaining hooks if headers have been sent
if (params.res.headersSent) {
return;
}
// eslint-disable-next-line no-await-in-loop
await hookObj.method(params);
}
}