Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-26 08:31:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove global window.templates

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-09-06 21:55:31 -04:00
parent fddeb5c0f8
commit 630bac2aa5
2 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
public/src/ajaxify.js
View File

@@ -327,6 +327,7 @@ ajaxify = window.ajaxify || {};
require(['translator', 'benchpress'], function (translator, Benchpress) { require(['translator', 'benchpress'], function (translator, Benchpress) {
translator.translate('[[error:no-connection]]'); translator.translate('[[error:no-connection]]');
Benchpress.registerLoader(ajaxify.loadTemplate); Benchpress.registerLoader(ajaxify.loadTemplate);
Benchpress.setGlobal('config', config);
}); });
}()); }());

16
public/src/app.js
View File

@@ -15,22 +15,6 @@ app.cacheBuster = null;
var registerMessage = params.register; var registerMessage = params.register;
var isTouchDevice = utils.isTouchDevice(); var isTouchDevice = utils.isTouchDevice();
require(['benchpress'], function (Benchpress) {
Benchpress.setGlobal('config', config);
if (Object.defineProperty) {
Object.defineProperty(window, 'templates', {
configurable: true,
enumerable: true,
get: function () {
console.warn('[deprecated] Accessing benchpress (formerly known as templates.js) globally is deprecated. Use `require(["benchpress"], function (Benchpress) { ... })` instead');
return Benchpress;
},
});
} else {
window.templates = Benchpress;
}
});
app.cacheBuster = config['cache-buster']; app.cacheBuster = config['cache-buster'];
bootbox.setDefaults({ bootbox.setDefaults({