From 61d1f5650023e0cac7953fd5db1cf311de33558d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Tue, 9 Nov 2021 10:51:44 -0500 Subject: [PATCH] test: socket.emit doesnt exist in tests --- src/socket.io/admin/user.js | 6 ++++-- src/socket.io/index.js | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/socket.io/admin/user.js b/src/socket.io/admin/user.js index e813053137..abb12cceed 100644 --- a/src/socket.io/admin/user.js +++ b/src/socket.io/admin/user.js @@ -172,7 +172,9 @@ User.exportUsersCSV = async function (socket) { setTimeout(async () => { try { await user.exportUsersCSV(); - socket.emit('event:export-users-csv'); + if (socket.emit) { + socket.emit('event:export-users-csv'); + } const notifications = require('../../notifications'); const n = await notifications.create({ bodyShort: '[[notifications:users-csv-exported]]', @@ -182,7 +184,7 @@ User.exportUsersCSV = async function (socket) { }); await notifications.push(n, [socket.uid]); } catch (err) { - winston.error(err); + winston.error(err.stack); } }, 0); }; diff --git a/src/socket.io/index.js b/src/socket.io/index.js index 4d88ed51ee..4dd74db26f 100644 --- a/src/socket.io/index.js +++ b/src/socket.io/index.js @@ -253,7 +253,7 @@ Sockets.getCountInRoom = function (room) { }; Sockets.warnDeprecated = (socket, replacement) => { - if (socket.previousEvents) { + if (socket.previousEvents && socket.emit) { socket.emit('event:deprecated_call', { eventName: socket.previousEvents[socket.previousEvents.length - 1], replacement: replacement,