From 5da24b41204692e20ca255c65a325c9d91e37d0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Thu, 16 Nov 2017 10:55:55 -0500 Subject: [PATCH] https://github.com/NodeBB/NodeBB/issues/6073 --- src/socket.io/topics/tags.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/socket.io/topics/tags.js b/src/socket.io/topics/tags.js index fd0c0d0987..2c50999b70 100644 --- a/src/socket.io/topics/tags.js +++ b/src/socket.io/topics/tags.js @@ -7,7 +7,7 @@ var utils = require('../../utils'); module.exports = function (SocketTopics) { SocketTopics.isTagAllowed = function (socket, data, callback) { - if (!data || !data.cid || !data.tag) { + if (!data || !utils.isNumber(data.cid) || !data.tag) { return callback(new Error('[[error:invalid-data]]')); } async.waterfall([ @@ -15,10 +15,7 @@ module.exports = function (SocketTopics) { db.getSortedSetRange('cid:' + data.cid + ':tag:whitelist', 0, -1, next); }, function (tagWhitelist, next) { - if (!tagWhitelist.length) { - return next(null, true); - } - next(null, tagWhitelist.indexOf(data.tag) !== -1); + next(null, !tagWhitelist.length || tagWhitelist.includes(data.tag)); }, ], callback); };