From 566564ed74fe1cc8a9f4e0c9091294a1167d0b4e Mon Sep 17 00:00:00 2001 From: Baris Usakli Date: Fri, 26 Oct 2018 13:01:34 -0400 Subject: [PATCH] fix redis tests fixed typo in groups/data.js added postcount,viewcount to int fields --- src/groups/data.js | 2 +- src/topics/data.js | 3 ++- test/groups.js | 2 +- test/topics.js | 2 ++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/groups/data.js b/src/groups/data.js index 2115c35dc9..041a87fe9f 100644 --- a/src/groups/data.js +++ b/src/groups/data.js @@ -29,7 +29,7 @@ module.exports = function (Groups) { function (next) { const keys = groupNames.map(groupName => 'group:' + groupName); if (fields.length) { - db.getObjectsFields(keys, fields, callback); + db.getObjectsFields(keys, fields, next); } else { db.getObjects(keys, next); } diff --git a/src/topics/data.js b/src/topics/data.js index 9b4edbf944..9df72b5f0c 100644 --- a/src/topics/data.js +++ b/src/topics/data.js @@ -9,7 +9,8 @@ var utils = require('../utils'); var translator = require('../translator'); const intFields = [ - 'tid', 'cid', 'uid', 'mainPid', 'deleted', 'locked', 'pinned', + 'tid', 'cid', 'uid', 'mainPid', 'postcount', + 'viewcount', 'deleted', 'locked', 'pinned', 'timestamp', 'upvotes', 'downvotes', 'lastposttime', ]; diff --git a/test/groups.js b/test/groups.js index fe630d9d65..9e828b9edf 100644 --- a/test/groups.js +++ b/test/groups.js @@ -1339,7 +1339,7 @@ describe('Groups', function () { it('should remove cover', function (done) { socketGroups.cover.remove({ uid: adminUid }, { groupName: 'Test' }, function (err) { assert.ifError(err); - Groups.getGroupFields('Test', ['cover:url'], function (err, groupData) { + db.getObjectFields('group:Test', ['cover:url'], function (err, groupData) { assert.ifError(err); assert(!groupData['cover:url']); done(); diff --git a/test/topics.js b/test/topics.js index 53938bfd16..c506c50312 100644 --- a/test/topics.js +++ b/test/topics.js @@ -226,6 +226,8 @@ describe('Topic\'s', function () { assert(typeof topicData.mainPid === 'number'); assert(typeof topicData.timestamp === 'number'); + assert.strictEqual(topicData.postcount, 1); + assert.strictEqual(topicData.viewcount, 0); assert.strictEqual(topicData.upvotes, 0); assert.strictEqual(topicData.downvotes, 0); assert.strictEqual(topicData.votes, 0);