Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-08-27 00:55:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Document deprecations and remove old ones (#8706)

Browse Source 
* chore: document deprecation removal versions

* chore: remove deprecations 2+ versions old
This commit is contained in:
Peter Jaszkowiak
2020-10-01 10:25:03 -06:00
committed by GitHub
parent 017af63fb0
commit 55d5cccf2e
6 changed files with 5 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/controllers/accounts/helpers.js
View File

@@ -1,7 +1,6 @@
'use strict';
const validator = require('validator');
const winston = require('winston');
const nconf = require('nconf');
const user = require('../../user');
@@ -204,12 +203,6 @@ async function parseAboutMe(userData) {
function filterLinks(links, states) {
return links.filter(function (link, index) {
// "public" is the old property, if visibility is defined, discard `public`
if (link.hasOwnProperty('public') && !link.hasOwnProperty('visibility')) {
winston.warn('[account/profileMenu (' + link.id + ')] Use of the `.public` property is deprecated, use `visibility` now');
return link && (link.public || states.self);
}
// Default visibility
link.visibility = { self: true,
other: true,

8
src/controllers/uploads.js
View File

@@ -3,8 +3,6 @@
const path = require('path');
const nconf = require('nconf');
const validator = require('validator');
const winston = require('winston');
const util = require('util');
const db = require('../database');
const meta = require('../meta');
@@ -26,12 +24,6 @@ uploadsController.upload = async function (req, res, filesIterator) {
files = files[0];
}
// backwards compatibility
if (filesIterator.constructor && filesIterator.constructor.name !== 'AsyncFunction') {
winston.warn('[deprecated] uploadsController.upload, use an async function as iterator');
filesIterator = util.promisify(filesIterator);
}
try {
const images = [];
for (const fileObj of files) {