From 1d5e15eab40192d508680ba380eb59c37bad9ad3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Mon, 23 Feb 2015 13:39:17 -0500
Subject: [PATCH 1/7] closes #2560

---
 public/language/en_GB/error.json |  1 +
 public/src/app.js                | 16 +++++++++++++++-
 src/middleware/middleware.js     |  4 ++--
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/public/language/en_GB/error.json b/public/language/en_GB/error.json
index 812ae03a17..b2f9a3b86b 100644
--- a/public/language/en_GB/error.json
+++ b/public/language/en_GB/error.json
@@ -24,6 +24,7 @@
 	"email-taken": "Email taken",
 	"email-not-confirmed": "Your email has not been confirmed yet, please click here to confirm your email.",
 	"email-not-confirmed-chat": "You are unable to chat until your email is confirmed",
+	"no-email-to-confirm": "This forum requires email confirmation, please click here to enter an email",
 
 	"username-too-short": "Username too short",
 	"username-too-long": "Username too long",
diff --git a/public/src/app.js b/public/src/app.js
index b4a091f960..d3a47a1bc6 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -570,7 +570,21 @@ app.cacheBuster = null;
 	};
 
 	function showEmailConfirmWarning() {
-		if (config.requireEmailConfirmation && app.user.uid && !app.user['email:confirmed']) {
+		if (!config.requireEmailConfirmation || !app.user.uid) {
+			return;
+		}
+		if (!app.user.email) {
+			app.alert({
+				alert_id: 'email_confirm',
+				message: '[[error:no-email-to-confirm]]',
+				type: 'warning',
+				timeout: 0,
+				clickfn: function() {
+					app.removeAlert('email_confirm');
+					ajaxify.go('user/' + app.user.userslug + '/edit');
+				}
+			});
+		} else if (!app.user['email:confirmed']) {
 			app.alert({
 				alert_id: 'email_confirm',
 				message: '[[error:email-not-confirmed]]',
diff --git a/src/middleware/middleware.js b/src/middleware/middleware.js
index 43e2a2ea86..658b9e0c63 100644
--- a/src/middleware/middleware.js
+++ b/src/middleware/middleware.js
@@ -317,7 +317,7 @@ middleware.renderHeader = function(req, res, callback) {
 			},
 			user: function(next) {
 				if (uid) {
-					user.getUserFields(uid, ['username', 'userslug', 'picture', 'status', 'email:confirmed', 'banned'], next);
+					user.getUserFields(uid, ['username', 'userslug', 'email', 'picture', 'status', 'email:confirmed', 'banned'], next);
 				} else {
 					next(null, {
 						username: '[[global:guest]]',
@@ -342,7 +342,7 @@ middleware.renderHeader = function(req, res, callback) {
 			results.user.isAdmin = results.isAdmin || false;
 			results.user.uid = parseInt(results.user.uid, 10);
 			results.user['email:confirmed'] = parseInt(results.user['email:confirmed'], 10) === 1;
-
+			
 			templateValues.browserTitle = results.title;
 			templateValues.isAdmin = results.user.isAdmin;
 			templateValues.user = results.user;

From e6e755dd4617a3b15bab1fc3eb1c526fc10b4295 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Mon, 23 Feb 2015 14:05:43 -0500
Subject: [PATCH 2/7] #2560

---
 src/middleware/admin.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/middleware/admin.js b/src/middleware/admin.js
index a7ed1997fb..a23781fdef 100644
--- a/src/middleware/admin.js
+++ b/src/middleware/admin.js
@@ -40,13 +40,14 @@ middleware.buildHeader = function(req, res, next) {
 				'authentication': []
 			};
 
-			user.getUserFields(uid, ['username', 'userslug', 'picture', 'email:confirmed'], function(err, userData) {
+			user.getUserFields(uid, ['username', 'userslug', 'email', 'picture', 'email:confirmed'], function(err, userData) {
 				if (err) {
 					return next(err);
 				}
 
 				userData.uid = uid;
-
+				userData['email:confirmed'] = parseInt(userData['email:confirmed'], 10) === 1;
+				
 				async.parallel({
 					scripts: function(next) {
 						plugins.fireHook('filter:admin.scripts.get', [], function(err, scripts) {
@@ -72,16 +73,15 @@ middleware.buildHeader = function(req, res, next) {
 						return next(err);
 					}
 					res.locals.config = results.config;
+
 					var data = {
 						relative_path: nconf.get('relative_path'),
 						configJSON: JSON.stringify(results.config),
+						user: userData,
 						userJSON: JSON.stringify(userData),
 						plugins: results.custom_header.plugins,
 						authentication: results.custom_header.authentication,
 						scripts: results.scripts,
-						userpicture: userData.picture,
-						username: userData.username,
-						userslug: userData.userslug,
 						'cache-buster': meta.config['cache-buster'] ? 'v=' + meta.config['cache-buster'] : '',
 						env: process.env.NODE_ENV ? true : false
 					};

From 89f2520eba2434e5ff6304f07f1ac5475a61268b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Mon, 23 Feb 2015 14:07:51 -0500
Subject: [PATCH 3/7] #2560 fix user link pic

---
 src/views/admin/header.tpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/views/admin/header.tpl b/src/views/admin/header.tpl
index 7a5d658eb2..89b0dc4ac4 100644
--- a/src/views/admin/header.tpl
+++ b/src/views/admin/header.tpl
@@ -85,11 +85,11 @@
                     </li>
                     <li id="user_label" class="dropdown pull-right">
                         <a class="dropdown-toggle" data-toggle="dropdown" href="#" id="user_dropdown">
-                            <img src="{userpicture}"/>
+                            <img src="{user.picture}"/>
                         </a>
                         <ul id="user-control-list" class="dropdown-menu" aria-labelledby="user_dropdown">
                             <li>
-                                <a id="user-profile-link" href="{relative_path}/user/{userslug}" target="_top"><span>Profile</span></a>
+                                <a id="user-profile-link" href="{relative_path}/user/{user.userslug}" target="_top"><span>Profile</span></a>
                             </li>
                             <li id="logout-link">
                                 <a href="#">Log out</a>

From f63ecac8ee09fdc9be3e07456a6f93b5ca76d103 Mon Sep 17 00:00:00 2001
From: psychobunny <psycho.bunny@hotmail.com>
Date: Mon, 23 Feb 2015 14:11:30 -0500
Subject: [PATCH 4/7] upgrade script for nodebb-rewards-essentials

---
 src/upgrade.js | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/src/upgrade.js b/src/upgrade.js
index 117b79848e..6e7751847a 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -21,7 +21,7 @@ var db = require('./database'),
 	schemaDate, thisSchemaDate,
 
 	// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema
-	latestSchema = Date.UTC(2015, 1, 17);
+	latestSchema = Date.UTC(2015, 1, 23);
 
 Upgrade.check = function(callback) {
 	db.get('schemaDate', function(err, value) {
@@ -859,6 +859,24 @@ Upgrade.upgrade = function(callback) {
 				winston.info('[2015/02/17] renaming home.tpl to categories.tpl skipped');
 				next();
 			}
+		},
+		function(next) {
+			thisSchemaDate = Date.UTC(2015, 1, 23);
+			if (schemaDate < thisSchemaDate) {
+				db.setAdd('plugins:active', 'nodebb-rewards-essentials', function(err) {
+					winston.info('[2015/2/23] Activating NodeBB Essential Rewards');
+					Plugins.reload(function() {
+						if (err) {
+							next(err);
+						} else {
+							Upgrade.update(thisSchemaDate, next);
+						}
+					});
+				});
+			} else {
+				winston.info('[2015/2/23] Activating NodeBB Essential Rewards - skipped');
+				next();
+			}
 		}
 
 		// Add new schema updates here

From 44c6375d918ac5baae806006f505ce29dd44f315 Mon Sep 17 00:00:00 2001
From: psychobunny <psycho.bunny@hotmail.com>
Date: Mon, 23 Feb 2015 14:11:43 -0500
Subject: [PATCH 5/7] it's on line 24 now

---
 src/upgrade.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/upgrade.js b/src/upgrade.js
index 6e7751847a..8d247c451c 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -880,7 +880,7 @@ Upgrade.upgrade = function(callback) {
 		}
 
 		// Add new schema updates here
-		// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema IN LINE 22!!!
+		// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema IN LINE 24!!!
 	], function(err) {
 		if (!err) {
 			if(updatesMade) {

From ee377b160ea94cd79d5e60c9b46d7cb1648f2624 Mon Sep 17 00:00:00 2001
From: psychobunny <psycho.bunny@hotmail.com>
Date: Mon, 23 Feb 2015 14:55:59 -0500
Subject: [PATCH 6/7] #2751 fixes syntax error on acp/ajaxify

---
 public/src/admin/extend/rewards.js | 74 +++++++++++++++---------------
 1 file changed, 36 insertions(+), 38 deletions(-)

diff --git a/public/src/admin/extend/rewards.js b/public/src/admin/extend/rewards.js
index 7fc023eda5..45e81cc289 100644
--- a/public/src/admin/extend/rewards.js
+++ b/public/src/admin/extend/rewards.js
@@ -11,50 +11,48 @@ define('admin/extend/rewards', function() {
 		conditionals;
 
 	rewards.init = function() {
-		$(window).on('action:ajaxify.end', function() {
-			available = JSON.parse(ajaxify.variables.get('rewards'));
-			active = JSON.parse(ajaxify.variables.get('active'));
-			conditions = JSON.parse(ajaxify.variables.get('conditions'));
-			conditionals = JSON.parse(ajaxify.variables.get('conditionals'));
+		available = JSON.parse(ajaxify.variables.get('rewards'));
+		active = JSON.parse(ajaxify.variables.get('active'));
+		conditions = JSON.parse(ajaxify.variables.get('conditions'));
+		conditionals = JSON.parse(ajaxify.variables.get('conditionals'));
 
-			$('[data-selected]').each(function() {
-				select($(this));
-			});
+		$('[data-selected]').each(function() {
+			select($(this));
+		});
 
-			$('#active')
-				.on('change', '[data-selected]', function() {
-					update($(this));
-				})
-				.on('click', '.delete', function() {
-					var parent = $(this).parents('[data-id]'),
-						id = parent.attr('data-id');
+		$('#active')
+			.on('change', '[data-selected]', function() {
+				update($(this));
+			})
+			.on('click', '.delete', function() {
+				var parent = $(this).parents('[data-id]'),
+					id = parent.attr('data-id');
 
-					socket.emit('admin.rewards.delete', {id: id}, function(err) {
-						if (err) {
-							app.alertError(err.message);
-						} else {
-							app.alertSuccess('Successfully deleted reward');
-						}
-					});
-
-					parent.remove();
-					return false;
-				})
-				.on('click', '.toggle', function() {
-					var btn = $(this),
-						disabled = btn.html() === 'Enable',
-						id = $(this).parents('[data-id]').attr('data-id');
-
-					btn.toggleClass('btn-warning').toggleClass('btn-success').html(disabled ? 'Enable' : 'Disable');
-					// send disable api call
-					return false;
+				socket.emit('admin.rewards.delete', {id: id}, function(err) {
+					if (err) {
+						app.alertError(err.message);
+					} else {
+						app.alertSuccess('Successfully deleted reward');
+					}
 				});
 
-			$('#new').on('click', newReward);
-			$('#save').on('click', saveRewards);
+				parent.remove();
+				return false;
+			})
+			.on('click', '.toggle', function() {
+				var btn = $(this),
+					disabled = btn.html() === 'Enable',
+					id = $(this).parents('[data-id]').attr('data-id');
 
-			populateInputs();
-		});
+				btn.toggleClass('btn-warning').toggleClass('btn-success').html(disabled ? 'Enable' : 'Disable');
+				// send disable api call
+				return false;
+			});
+
+		$('#new').on('click', newReward);
+		$('#save').on('click', saveRewards);
+
+		populateInputs();
 	};
 
 	function select(el) {

From 55884220b40b221484d2cd510a361de151f5ae77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Mon, 23 Feb 2015 14:57:22 -0500
Subject: [PATCH 7/7] #2749 upgrade plugins:active to zset

---
 app.js                 |  2 +-
 src/install.js         |  5 ++++-
 src/plugins.js         |  5 ++---
 src/plugins/install.js | 13 +++++++++++--
 src/upgrade.js         | 39 ++++++++++++++++++++++++++++++++++++++-
 5 files changed, 56 insertions(+), 8 deletions(-)

diff --git a/app.js b/app.js
index dcdf8e1819..f208072719 100644
--- a/app.js
+++ b/app.js
@@ -323,7 +323,7 @@ function resetThemes(callback) {
 
 function resetPlugin(pluginId) {
 	var db = require('./src/database');
-	db.setRemove('plugins:active', pluginId, function(err) {
+	db.sortedSetRemove('plugins:active', pluginId, function(err) {
 		if (err) {
 			winston.error('[reset] Could not disable plugin: %s encountered error %s', pluginId, err.message);
 		} else {
diff --git a/src/install.js b/src/install.js
index 10c4d25e05..d3df90b267 100644
--- a/src/install.js
+++ b/src/install.js
@@ -426,7 +426,10 @@ function enableDefaultPlugins(next) {
 		'nodebb-plugin-soundpack-default'
 	];
 	var	db = require('./database');
-	db.setAdd('plugins:active', defaultEnabled, next);
+	var order = defaultEnabled.map(function(plugin, index) {
+		return index;
+	});
+	db.sortedSetAdd('plugins:active', order, defaultEnabled, next);
 }
 
 function setCopyrightWidget(next) {
diff --git a/src/plugins.js b/src/plugins.js
index eed2db94b8..091a54daa6 100644
--- a/src/plugins.js
+++ b/src/plugins.js
@@ -92,13 +92,12 @@ var fs = require('fs'),
 		Plugins.clientScripts.length = 0;
 		Plugins.libraryPaths.length = 0;
 
-		// Read the list of activated plugins and require their libraries
 		async.waterfall([
 			function(next) {
-				db.getSetMembers('plugins:active', next);
+				db.getSortedSetRange('plugins:active', 0, -1, next);
 			},
 			function(plugins, next) {
-				if (!plugins || !Array.isArray(plugins)) {
+				if (!Array.isArray(plugins)) {
 					return next();
 				}
 
diff --git a/src/plugins/install.js b/src/plugins/install.js
index a95f16b3b1..06dcbbf659 100644
--- a/src/plugins/install.js
+++ b/src/plugins/install.js
@@ -38,7 +38,16 @@ module.exports = function(Plugins) {
 			},
 			function(_isActive, next) {
 				isActive = _isActive;
-				db[isActive ? 'setRemove' : 'setAdd']('plugins:active', id, next);
+				if (isActive) {
+					db.sortedSetRemove('plugins:active', id, next);
+				} else {
+					db.sortedSetCard('plugins:active', function(err, count) {
+						if (err) {
+							return next(err);
+						}
+						db.sortedSetAdd('plugins:active', count, id, next);	
+					});				
+				}
 			},
 			function(next) {
 				meta.reloadRequired = true;
@@ -119,6 +128,6 @@ module.exports = function(Plugins) {
 	};
 
 	Plugins.isActive = function(id, callback) {
-		db.isSetMember('plugins:active', id, callback);
+		db.isSortedSetMember('plugins:active', id, callback);
 	};
 };
\ No newline at end of file
diff --git a/src/upgrade.js b/src/upgrade.js
index 117b79848e..05f8bd5fef 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -21,7 +21,7 @@ var db = require('./database'),
 	schemaDate, thisSchemaDate,
 
 	// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema
-	latestSchema = Date.UTC(2015, 1, 17);
+	latestSchema = Date.UTC(2015, 1, 23);
 
 Upgrade.check = function(callback) {
 	db.get('schemaDate', function(err, value) {
@@ -859,6 +859,43 @@ Upgrade.upgrade = function(callback) {
 				winston.info('[2015/02/17] renaming home.tpl to categories.tpl skipped');
 				next();
 			}
+		},
+		function(next) {
+			thisSchemaDate = Date.UTC(2015, 1, 23);
+			if (schemaDate < thisSchemaDate) {
+				updatesMade = true;
+				winston.info('[2015/02/23] Upgrading plugins:active to sorted set');
+
+				db.getSetMembers('plugins:active', function(err, activePlugins) {
+					if (err) {
+						return next(err);
+					}
+					if (!Array.isArray(activePlugins) || !activePlugins.length) {
+						winston.info('[2015/02/23] Upgrading plugins:active to sorted set done');
+						Upgrade.update(thisSchemaDate, next);
+					}
+
+					db.delete('plugins:active', function(err) {
+						if (err) {
+							return next(err);
+						}
+						var order = -1;
+						async.eachSeries(activePlugins, function(plugin, next) {
+							++order;
+							db.sortedSetAdd('plugins:active', order, plugin, next);
+						}, function(err) {
+							if (err) {
+								return next(err);
+							}
+							winston.info('[2015/02/23] Upgrading plugins:active to sorted set done');
+							Upgrade.update(thisSchemaDate, next);
+						});
+					});
+				});
+			} else {
+				winston.info('[2015/02/23] Upgrading plugins:active to sorted set skipped');
+				next();
+			}
 		}
 
 		// Add new schema updates here