From 438fa5c88f92f03d7b1e0d7d4cce5621ea3ff413 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Thu, 17 Dec 2020 14:01:08 -0500
Subject: [PATCH] fix: send fewer items to client-side for ACP settings/email
 page

---
 src/controllers/admin/settings.js  | 2 +-
 src/views/admin/settings/email.tpl | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/controllers/admin/settings.js b/src/controllers/admin/settings.js
index e49a4755ae..46bca36835 100644
--- a/src/controllers/admin/settings.js
+++ b/src/controllers/admin/settings.js
@@ -22,7 +22,7 @@ settingsController.email = async (req, res) => {
 
 	res.render('admin/settings/email', {
 		emails: emails,
-		sendable: emails.filter(e => !e.path.includes('_plaintext') && !e.path.includes('partials')),
+		sendable: emails.filter(e => !e.path.includes('_plaintext') && !e.path.includes('partials')).map(tpl => tpl.path),
 		services: emailer.listServices(),
 	});
 };
diff --git a/src/views/admin/settings/email.tpl b/src/views/admin/settings/email.tpl
index 3e54b08e1f..6b856526ef 100644
--- a/src/views/admin/settings/email.tpl
+++ b/src/views/admin/settings/email.tpl
@@ -121,7 +121,7 @@
 			<label>[[admin/settings/email:testing.select]]</label>
 			<select id="test-email" class="form-control">
 				<!-- BEGIN sendable -->
-				<option value="{sendable.path}">{sendable.path}</option>
+				<option value="{@value}">{@value}</option>
 				<!-- END sendable -->
 			</select>
 		</div>