Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-07-13 21:21:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: change owner missing await

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-01-17 11:16:23 -05:00
parent 09d55581d8
commit 3e52557689
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/posts/user.js
View File

@@ -123,7 +123,7 @@ module.exports = function (Posts) {
}; };
Posts.changeOwner = async function (pids, toUid) { Posts.changeOwner = async function (pids, toUid) {
const exists = user.exists(toUid); const exists = await user.exists(toUid);
if (!exists) { if (!exists) {
throw new Error('[[error:no-user]]'); throw new Error('[[error:no-user]]');
} }

8
test/posts.js
View File

@@ -134,6 +134,14 @@ describe('Post\'s', function () {
assert.strictEqual(await topics.isOwner(postResult.topicData.tid, newUid), true); assert.strictEqual(await topics.isOwner(postResult.topicData.tid, newUid), true);
}); });
it('should fail to change owner if new owner does not exist', async function () {
try {
await posts.changeOwner([1], '9999999');
} catch (err) {
assert.strictEqual(err.message, '[[error:no-user]]');
}
});
it('should return falsy if post does not exist', function (done) { it('should return falsy if post does not exist', function (done) {
posts.getPostData(9999, function (err, postData) { posts.getPostData(9999, function (err, postData) {
assert.ifError(err); assert.ifError(err);