From 3b57d3eadb1888e347ec153aaf85210ba72eefa6 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Thu, 5 Apr 2018 14:35:49 -0400
Subject: [PATCH] closes #6434

---
 src/plugins/hooks.js | 36 +++++++++++++++++++++++-------------
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/src/plugins/hooks.js b/src/plugins/hooks.js
index c555424377..9133378ace 100644
--- a/src/plugins/hooks.js
+++ b/src/plugins/hooks.js
@@ -12,20 +12,24 @@ module.exports = function (Plugins) {
 		'action:flag.create': 'action:flags.create',
 		'action:flag.update': 'action:flags.update',
 	};
-	/*
-		`data` is an object consisting of (* is required):
-			`data.hook`*, the name of the NodeBB hook
-			`data.method`*, the method called in that plugin
-			`data.priority`, the relative priority of the method when it is eventually called (default: 10)
-	*/
-	Plugins.registerHook = function (id, data, callback) {
-		callback = callback || function () {};
-		function register() {
+
+	Plugins.internals = {
+		_register: function (data, callback) {
 			Plugins.loadedHooks[data.hook] = Plugins.loadedHooks[data.hook] || [];
 			Plugins.loadedHooks[data.hook].push(data);
 
 			callback();
-		}
+		},
+	};
+
+	/*
+		`data` is an object consisting of (* is required):
+			`data.hook`*, the name of the NodeBB hook
+			`data.method`*, the method called in that plugin (can be an array of functions)
+			`data.priority`, the relative priority of the method when it is eventually called (default: 10)
+	*/
+	Plugins.registerHook = function (id, data, callback) {
+		callback = callback || function () {};
 
 		if (!data.hook) {
 			winston.warn('[plugins/' + id + '] registerHook called with invalid data.hook', data);
@@ -48,7 +52,13 @@ module.exports = function (Plugins) {
 				data.priority = 10;
 			}
 
-			if (typeof data.method === 'string' && data.method.length > 0) {
+			if (Array.isArray(data.method) && data.method.every(method => typeof method === 'function' || typeof method === 'string')) {
+				// Go go gadget recursion!
+				async.eachSeries(data.method, function (method, next) {
+					const singularData = Object.assign({}, data, { method: method });
+					Plugins.registerHook(id, singularData, next);
+				}, callback);
+			} else if (typeof data.method === 'string' && data.method.length > 0) {
 				method = data.method.split('.').reduce(function (memo, prop) {
 					if (memo && memo[prop]) {
 						return memo[prop];
@@ -60,9 +70,9 @@ module.exports = function (Plugins) {
 				// Write the actual method reference to the hookObj
 				data.method = method;
 
-				register();
+				Plugins.internals._register(data, callback);
 			} else if (typeof data.method === 'function') {
-				register();
+				Plugins.internals._register(data, callback);
 			} else {
 				winston.warn('[plugins/' + id + '] Hook method mismatch: ' + data.hook + ' => ' + data.method);
 				return callback();