From 39f57f9e5b177d1a50de6ec0f3d17d8aa4e28444 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Fri, 4 Oct 2024 15:44:19 -0400
Subject: [PATCH] refactor: don't block ./nodebb upgrade if suggested modules
 are not loaded

---
 src/cli/upgrade-plugins.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/cli/upgrade-plugins.js b/src/cli/upgrade-plugins.js
index cb6cbce94b..b68db55eac 100644
--- a/src/cli/upgrade-plugins.js
+++ b/src/cli/upgrade-plugins.js
@@ -77,7 +77,8 @@ async function getSuggestedModules(nbbVersion, toCheck) {
 	const request = require('../request');
 	let { response, body } = await request.get(`https://packages.nodebb.org/api/v1/suggest?version=${nbbVersion}&package[]=${toCheck.join('&package[]=')}`);
 	if (!response.ok) {
-		throw new Error(`Unable to get suggested module for NodeBB(${nbbVersion}) ${toCheck.join(',')}`);
+		console.warn(`Unable to get suggested module for NodeBB(${nbbVersion}) ${toCheck.join(',')}`);
+		return [];
 	}
 	if (!Array.isArray(body) && toCheck.length === 1) {
 		body = [body];