From 381e64e657bd5099be459877613db35d5f14216a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Sun, 17 Dec 2023 12:54:22 -0500
Subject: [PATCH] plugins

---
 test/plugins.js | 36 ++++++++++++++----------------------
 1 file changed, 14 insertions(+), 22 deletions(-)

diff --git a/test/plugins.js b/test/plugins.js
index 2ffbf604c3..63c3d301ed 100644
--- a/test/plugins.js
+++ b/test/plugins.js
@@ -3,11 +3,12 @@
 const assert = require('assert');
 const path = require('path');
 const nconf = require('nconf');
-const request = require('request');
+
 const fs = require('fs');
 
 const db = require('./mocks/databasemock');
 const plugins = require('../src/plugins');
+const request = require('../src/request');
 
 describe('Plugins', () => {
 	it('should load plugin data', (done) => {
@@ -290,33 +291,24 @@ describe('Plugins', () => {
 	});
 
 	describe('static assets', () => {
-		it('should 404 if resource does not exist', (done) => {
-			request.get(`${nconf.get('url')}/plugins/doesnotexist/should404.tpl`, (err, res, body) => {
-				assert.ifError(err);
-				assert.equal(res.statusCode, 404);
-				assert(body);
-				done();
-			});
+		it('should 404 if resource does not exist', async () => {
+			const { response, body } = await request.get(`${nconf.get('url')}/plugins/doesnotexist/should404.tpl`, { validateStatus: null });
+			assert.equal(response.statusCode, 404);
+			assert(body);
 		});
 
-		it('should 404 if resource does not exist', (done) => {
+		it('should 404 if resource does not exist', async () => {
 			const url = `${nconf.get('url')}/plugins/nodebb-plugin-dbsearch/dbsearch/templates/admin/plugins/should404.tpl`;
-			request.get(url, (err, res, body) => {
-				assert.ifError(err);
-				assert.equal(res.statusCode, 404);
-				assert(body);
-				done();
-			});
+			const { response, body } = await request.get(url, { validateStatus: null });
+			assert.equal(response.statusCode, 404);
+			assert(body);
 		});
 
-		it('should get resource', (done) => {
+		it('should get resource', async () => {
 			const url = `${nconf.get('url')}/assets/templates/admin/plugins/dbsearch.tpl`;
-			request.get(url, (err, res, body) => {
-				assert.ifError(err);
-				assert.equal(res.statusCode, 200);
-				assert(body);
-				done();
-			});
+			const { response, body } = await request.get(url);
+			assert.equal(response.statusCode, 200);
+			assert(body);
 		});
 	});